[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Change by Nikita Sobolev :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Nikita Sobolev  added the comment:

During this work some people have mentioned that they actually use
`'__main__'` for local debugging of tests.
I don't think that I am familiar enough with the existing workflow to make
any educated decision :)

пн, 24 янв. 2022 г. в 19:34, Christian Heimes :

>
> Christian Heimes  added the comment:
>
> I noticed that you have been looking into the __main__ block of test
> modules. Wouldn't it make more sense to just remove the __main__ and have
> all tests go through regrtest? Everybody should use
>
>./python -m regrtest test_typing
>
> or the Windows equivalent to run typing tests.
>
> --
> nosy: +christian.heimes
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Christian Heimes]

Christian Heimes  added the comment:

I noticed that you have been looking into the __main__ block of test modules. 
Wouldn't it make more sense to just remove the __main__ and have all tests go 
through regrtest? Everybody should use

   ./python -m regrtest test_typing

or the Windows equivalent to run typing tests.

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Ken Jin]

Ken Jin  added the comment:


New changeset eaeb99468045b863d2dd3da3e3d1c3c9c78e1254 by Nikita Sobolev in 
branch '3.10':
[3.10] bpo-46416: Allow direct invocation of `Lib/test/test_typing.py` 
(GH-30641) (GH-30697)
https://github.com/python/cpython/commit/eaeb99468045b863d2dd3da3e3d1c3c9c78e1254


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Change by Nikita Sobolev :


--
pull_requests: +28903
pull_request: https://github.com/python/cpython/pull/30707

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Change by Nikita Sobolev :


--
pull_requests: +28896
pull_request: https://github.com/python/cpython/pull/30698

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Change by Nikita Sobolev :


--
pull_requests: +28895
pull_request: https://github.com/python/cpython/pull/30697

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Ken Jin]

Ken Jin  added the comment:


New changeset 2792d6d18eab3efeb71e6397f88db86e610541f1 by Nikita Sobolev in 
branch 'main':
bpo-46416: Allow direct invocation of `Lib/test/test_typing.py` (GH-30641)
https://github.com/python/cpython/commit/2792d6d18eab3efeb71e6397f88db86e610541f1


--
nosy: +kj

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +28844
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30641

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46416] Direct invocation of `Lib/test/test_typing.py` fails

[Nikita Sobolev]

New submission from Nikita Sobolev :

Here's the problem:

```
» ./python.exe Lib/test/test_typing.py
s.F.
==
FAIL: test_special_attrs2 (__main__.SpecialAttrsTests)
--
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_typing.py", line 5068, in 
test_special_attrs2
self.assertEqual(
^
AssertionError: '__main__' != 'test.test_typing'
- __main__
+ test.test_typing
```

I think it is a good idea to use the same hack we have in `test_enum.py`: 
https://github.com/python/cpython/blob/83d544b9292870eb44f6fca37df0aa351c4ef83a/Lib/test/test_enum.py#L34

```python
MODULE = ('test.test_typing', '__main__')[__name__=='__main__']
```

PR is on its way :)

--
components: Tests
messages: 410800
nosy: sobolevn
priority: normal
severity: normal
status: open
title: Direct invocation of `Lib/test/test_typing.py` fails
type: behavior
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com