[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[miss-islington]

miss-islington  added the comment:


New changeset f2fbfbe0ec57ec39b3099dae62571a48d5fe8729 by Miss Islington (bot) 
in branch '3.10':
bpo-46483: [doc] pathlib classes no longer support parameterized generics 
(GH-31281)
https://github.com/python/cpython/commit/f2fbfbe0ec57ec39b3099dae62571a48d5fe8729


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[miss-islington]

miss-islington  added the comment:


New changeset a7c1cc41696740bb528f4d24816c59e38b8be345 by Miss Islington (bot) 
in branch '3.9':
bpo-46483: [doc] pathlib classes no longer support parameterized generics 
(GH-31281)
https://github.com/python/cpython/commit/a7c1cc41696740bb528f4d24816c59e38b8be345


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[miss-islington]

Change by miss-islington :


--
pull_requests: +29447
pull_request: https://github.com/python/cpython/pull/31287

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 7.0 -> 8.0
pull_requests: +29446
pull_request: https://github.com/python/cpython/pull/31286

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e0bc8ee945af96f9395659bbe3cc30b082e7a361 by Alex Waygood in 
branch 'main':
bpo-46483: [doc] pathlib classes no longer support parameterized generics 
(GH-31281)
https://github.com/python/cpython/commit/e0bc8ee945af96f9395659bbe3cc30b082e7a361


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Alex Waygood]

Change by Alex Waygood :


--
pull_requests: +29441
pull_request: https://github.com/python/cpython/pull/31281

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 7ffe7ba30fc051014977c6f393c51e57e71a6648 by Nikita Sobolev in 
branch 'main':
bpo-46483: Remove `__class_getitem__` from `pathlib.PurePath` (GH-30848)
https://github.com/python/cpython/commit/7ffe7ba30fc051014977c6f393c51e57e71a6648


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Alex Waygood]

Alex Waygood  added the comment:

The desmper121 user appears to be a spammer; I am undoing all the changes they 
made to this BPO ticket.

--
nosy:  -barry, lys.nikolaou, pablogsal, r.david.murray, yselivanov
type:  -> behavior
versions:  -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It is not related to email and asyncio either.

--
components:  -asyncio, email

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This issue is not related to the parser, so I am unmarking it.

--
components:  -Parser

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Popo Al]

Change by Popo Al :


--
components: +Parser, asyncio, email
nosy: +barry, lys.nikolaou, pablogsal, r.david.murray, yselivanov
type: behavior -> 
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Guido van Rossum]

Change by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Jelle Zijlstra]

Change by Jelle Zijlstra :


--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Andrew Svetlov]

Andrew Svetlov  added the comment:

IIRC it was added to reflect the presence of __class_getitem__ method in 
typeshed.
Please feel free to drop it the method is not really needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Nikita Sobolev]

Change by Nikita Sobolev :


--
pull_requests: +29030
pull_request: https://github.com/python/cpython/pull/30848

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Alex Waygood]

Alex Waygood  added the comment:

It looks like __class_getitem__ was added to PurePath at @asvetlov's request  
in PR 17498. But, I'm also not quite sure why. The class is not generic in 
typeshed, so type-checkers will raise an error if you do PurePath[str], even if 
it is possible to do so at runtime.

Typeshed stub for PurePath: 
https://github.com/python/typeshed/blob/dff461fc6adef1ec3a4b58af5abdf0cdebf2429a/stdlib/pathlib.pyi#L20

--
nosy: +AlexWaygood, asvetlov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Why __class_getitem__ was added in PurePath at first place? PurePath should not 
be a generic class, unlike to os.PathLike. For os.PathLike the type parameters 
represent the returning type of os.fspath() (either str or bytes), but the 
pathlib module only supports paths as strings, so no parametrization is needed.

I think PurePath.__class_getitem__ should be removed.

--
nosy: +gvanrossum, kj, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:


New changeset 1f715d5bd3bc9ff444e109b6bbd13011913681b1 by Nikita Sobolev in 
branch 'main':
bpo-46483: change `PurePath.__class_getitem__` to return `GenericAlias` 
(GH-30822)
https://github.com/python/cpython/commit/1f715d5bd3bc9ff444e109b6bbd13011913681b1


--
nosy: +BTaskaya

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Nikita Sobolev]

Change by Nikita Sobolev :


--
keywords: +patch
pull_requests: +29009
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30822

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46483] `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`

[Nikita Sobolev]

New submission from Nikita Sobolev :

After reviewing https://github.com/python/cpython/pull/30777 I had a chance to 
look through other definitions of `def __class_getitem__`. And I found that the 
only one left is: `pathlib.PurePath.__class_getitem__`

All other definitions already have this form: `__class_getitem__ = 
classmethod(GenericAlias)`.

I don't think that there's anything special about `PurePath` in this regard. 
So, I propose to make `__class_getitem__` to return `GenericAlias` as all other 
types do.

Initial PR: https://github.com/python/cpython/pull/17498

PR is on its way.

--
components: Library (Lib)
messages: 411354
nosy: sobolevn
priority: normal
severity: normal
status: open
title: `pathlib.PurePath.__class_getitem__` does not return `GenericAlias`
type: behavior
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com