[issue4653] Patch to fix typos for Py3K

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
versions: +Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[STINNER Victor]

STINNER Victor  added the comment:

I fixed the typo in pythonrun.c: r81156. I don't use Windows, so I cannot 
review the other fixes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

I don't run Windows either but I believe sizeof(char) == 1 is guaranteed by the 
C standard, so the first report (Python/dynload_win.c) is invalid.

The last two appear to be valid [1], and a common mistake. [2]  Unit tests are 
needed for these.  I also notice that r81156 does not add a unit test either.  
ISTM, a test case can be crafted by setting sys.stderr to None.

[1] http://msdn.microsoft.com/en-us/library/aa366537(VS.85).aspx
[2] http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx

--
components: +Windows
nosy: +belopolsky
stage: commit review -> unit test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Strike my comment about Python/dynload_win.c - I was looking at the trunk 
version instead of py3k.  In py3k theInfo is wchar_t and patch seems to be 
valid.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
versions: +Python 3.3 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

New submission from Johnny Lee :

I ran my typo.pl perl script that locates possible C/C++ typos.

I found four that looked valid.

Two of the typos were in the Python directory {pythonrun.c, 
dynload_win.c}, two were in PC/bdist_wininst {install.c, extract.c}.

Python/dynload_win.c:
Win32 API FormatMessageW() expects the 6th parameter to be the count of 
characters, NOT the count of bytes.

Python/pythonrun.c:
The source code contains "if (ferr != NULL || ferr != Py_None)". This 
does not work as expected - if ferr == NULL, then the second part of 
the if expression will succeed. Look at the code handling fout about 8 
lines up to see the correct code.

PC/bdist_wininst/extract.c:
Win32 API CreateFileMapping returns NULL on error, not 
INVALID_HANDLE_VALUE.

PC/bdist_wininst/install.c:
Win32 API CreateFileMapping returns NULL on error, not 
INVALID_HANDLE_VALUE.

--
components: Installation, Interpreter Core
files: py30diff.txt
messages: 77718
nosy: typo.pl
severity: normal
status: open
title: Patch to fix typos for Py3K
versions: Python 3.0
Added file: http://bugs.python.org/file12335/py30diff.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I don't know Windows APIs but the pythonrun.c bug is genuine.

--
nosy: +pitrou
priority:  -> high
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

Johnny Lee  added the comment:

Here are the URLs to the MSDN documentation for CreateFileMapping and 
FormatMessage[A|W]:



For CreateFileMapping(), from the Return Value section:
"If the function fails, the return value is NULL. To get extended error 
information, call GetLastError."

For FormatMessage[A|W]:
nSize [in] 
If the FORMAT_MESSAGE_ALLOCATE_BUFFER flag is not set, this parameter 
specifies the size of the output buffer, in TCHARs.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

Johnny Lee  added the comment:

For the dynload_win.c typo, it's technically a possible buffer 
overflow, but you'd need to find an error that had an error message 
that's longer than 259 chars.

In pythonrun.c, the if statements for fout and ferr and almost 
identical. Probably a good idea to convert the if-statement to a 
separate function and call that function with fout and then ferr.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Mark Dickinson]

Mark Dickinson  added the comment:

It looks to me as though all these are valid, and the patch should be 
applied to py3k and the 3.0 maintenance branch.

Minor nit: the "sizeof(theInfo)" line exceeds 79 characters, in violation 
of PEP 7.

Is there any core developer who's in a position to test this patch on 
Windows?

--
nosy: +marketdickinson
stage:  -> commit review
versions: +Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

It's difficult to really test such errors.

Moreover, on the top of the bdist_wininst files, a comment says loudly:  
IF CHANGES TO THIS FILE ARE CHECKED INTO PYTHON CVS, THE RECOMPILED 
BINARIES MUST BE CHECKED IN AS WELL!

--
nosy: +amaury.forgeotdarc, loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

Changes by Johnny Lee :


Removed file: http://bugs.python.org/file12335/py30diff.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

Johnny Lee  added the comment:

attached modified diff patch so line length <=79 chars

Added file: http://bugs.python.org/file12374/py30dif2.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4653] Patch to fix typos for Py3K

[Johnny Lee]

Johnny Lee  added the comment:

> It's difficult to really test such errors.

When I can't control the called function, I usually step through the 
code in a debugger and change the result variable in question to the 
appropriate value to see if the code handles failed function calls 
correctly. 

In the three Win32 API cases, it's clear that the failure path was not 
tested.

And I can't see how the ferr if statement was tested with a failure 
value either.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com