[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[Brett Cannon]

Change by Brett Cannon :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[Brett Cannon]

Brett Cannon  added the comment:


New changeset c2735b75afd530631efde4ddd3cb24bbdc285559 by Miss Islington (bot) 
in branch '3.10':
bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py 
(GH-31204) (GH-31207)
https://github.com/python/cpython/commit/c2735b75afd530631efde4ddd3cb24bbdc285559


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[miss-islington]

miss-islington  added the comment:


New changeset da576e08296490e94924421af71001bcfbccb317 by Jason Wilkes in 
branch 'main':
bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py 
(GH-31204)
https://github.com/python/cpython/commit/da576e08296490e94924421af71001bcfbccb317


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 1.0 -> 2.0
pull_requests: +29378
pull_request: https://github.com/python/cpython/pull/31207

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[Jason Wilkes]

Change by Jason Wilkes :


--
keywords: +patch
pull_requests: +29374
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31204

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46678] Invalid cross device link in Lib/test/support/import_helper.py

[Jason Wilkes]

New submission from Jason Wilkes :

In Lib/test/support/import_helper.py, the function make_legacy_pyc makes a call 
to os.rename which can fail when the source and target live on different 
devices. This happens (for example) when PYTHONPYCACHEPREFIX is set to a 
directory on a different device from where temporary files are stored. 
Replacing os.rename with shutil.move fixes it. Will submit a PR.

--
components: Tests
messages: 412791
nosy: notarealdeveloper
priority: normal
severity: normal
status: open
title: Invalid cross device link in Lib/test/support/import_helper.py
type: behavior
versions: Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com