[issue47131] Speedup test_unparse

[Jeremy Kloth]

Change by Jeremy Kloth :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47131] Speedup test_unparse

[Jeremy Kloth]

Jeremy Kloth  added the comment:

Resolved with merged PR.

--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47131] Speedup test_unparse

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 0f68c208fa6a36b6c8ad3d775e64292a665ba108 by Jeremy Kloth in 
branch 'main':
bpo-47131: Speedup AST comparisons in test_unparse by using node traversal 
(GH-32132)
https://github.com/python/cpython/commit/0f68c208fa6a36b6c8ad3d775e64292a665ba108


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47131] Speedup test_unparse

[Jeremy Kloth]

Change by Jeremy Kloth :


--
nosy: +vstinner
type:  -> performance

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47131] Speedup test_unparse

[Jeremy Kloth]

Change by Jeremy Kloth :


--
keywords: +patch
pull_requests: +30212
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/32132

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47131] Speedup test_unparse

[Jeremy Kloth]

New submission from Jeremy Kloth :

The string building and comparing of ast.dump() causes significant slowdowns on 
the large ASTs produced when doing the roundtrip test on the stdlib.

This PR avoids that cost by doing a direct node traversal and comparison.  It 
results in a 33% runtime improvement on machines to which I have access.

--
components: Tests
messages: 416082
nosy: jkloth
priority: normal
severity: normal
status: open
title: Speedup test_unparse
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com