[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

Change by Jeremy Kloth :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Steve Dower]

Steve Dower  added the comment:


New changeset a4c7752f3e00b75fd1e4603458b8c77a9fa3d4cb by Jeremy Kloth in 
branch '3.9':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/a4c7752f3e00b75fd1e4603458b8c77a9fa3d4cb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Steve Dower]

Steve Dower  added the comment:


New changeset 8bce3cb16df5b8ac06ac6b2cae177dd221780b2f by Jeremy Kloth in 
branch '3.10':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/8bce3cb16df5b8ac06ac6b2cae177dd221780b2f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

Change by Jeremy Kloth :


--
pull_requests: +30400
pull_request: https://github.com/python/cpython/pull/32347

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

Change by Jeremy Kloth :


--
pull_requests: +30399
pull_request: https://github.com/python/cpython/pull/32346

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

Jeremy Kloth  added the comment:

It seems so, as the zlib update was also backported to 3.9 and 3.10.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Steve Dower]

Steve Dower  added the comment:

Do we need to backport this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Steve Dower]

Steve Dower  added the comment:


New changeset 944f09adfcc59f54432ac2947cf95f3465d90e1e by Jeremy Kloth in 
branch 'main':
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-32337)
https://github.com/python/cpython/commit/944f09adfcc59f54432ac2947cf95f3465d90e1e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

Change by Jeremy Kloth :


--
keywords: +patch
pull_requests: +30393
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/32337

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47230] New compiler warnings with latest zlib

[Jeremy Kloth]

New submission from Jeremy Kloth :

The latest zlib (1.2.12) introduces 3 new compiler warnings.  Now being an 
external library, I do not think we generally patch them, so I propose to 
simply silence the warnings for the offending file.

For reference, the problem comes from:

--- deflate.h.old   2022-04-05 11:27:26.869042900 -0600
+++ deflate.h.new   2022-04-05 11:26:11.512039600 -0600
@@ -329,8 +329,8 @@
 # define _tr_tally_dist(s, distance, length, flush) \
   { uch len = (uch)(length); \
 ush dist = (ush)(distance); \
-s->sym_buf[s->sym_next++] = dist; \
-s->sym_buf[s->sym_next++] = dist >> 8; \
+s->sym_buf[s->sym_next++] = (uch)dist; \
+s->sym_buf[s->sym_next++] = (uch)(dist >> 8); \
 s->sym_buf[s->sym_next++] = len; \
 dist--; \
 s->dyn_ltree[_length_code[len]+LITERALS+1].Freq++; \

--
components: Build, Windows
messages: 416792
nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: New compiler warnings with latest zlib
type: compile error
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com