[issue4772] undesired switch fall-through in socketmodule.c

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Committed in all four branches, thank you.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Changes by Brian Curtin :


Added file: http://bugs.python.org/file16090/issue4772.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Changes by Brian Curtin :


Removed file: http://bugs.python.org/file16089/issue4772.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Brian Curtin  added the comment:

Minor change to the patch to correct for Antoine's suggestion.

--
Added file: http://bugs.python.org/file16089/issue4772.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Changes by Brian Curtin :


Removed file: http://bugs.python.org/file15665/issue4772.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Antoine Pitrou]

Antoine Pitrou  added the comment:

"makesockaddr" shouldn't be mentioned in the exception message, since it's just 
an internal helper function.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Changes by Brian Curtin :


--
priority:  -> normal
type:  -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Brian Curtin]

Brian Curtin  added the comment:

I think both AF_BLUETOOTH and AF_TIPC should raise ValueError since the
type of the argument is correct but it's not a good value. I piggybacked
on Amaury's patch and changed the exceptions with a patch against r77004.

--
nosy: +brian.curtin
Added file: http://bugs.python.org/file15665/issue4772.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[STINNER Victor]

STINNER Victor  added the comment:

makesockaddr() raise a TypeError("Invalid address type") for an 
invalid AF_TIPC address, but I would prefer a ValueError.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Georg Brandl]

Georg Brandl  added the comment:

TypeError or ValueError?

--
nosy: +georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

See attached patch.

--
keywords: +needs review, patch
nosy: +amaury.forgeotdarc
stage:  -> patch review
versions: +Python 2.6, Python 3.0
Added file: http://bugs.python.org/file12507/bluetooth.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4772] undesired switch fall-through in socketmodule.c

[dontbugme]

New submission from dontbugme :

makesockaddr() in socketmodule.c will fall through from AF_BLUETOOTH to
AF_PACKET if none of Bluetooth protocols match. That's not a very
appropriate thing to do.

--
messages: 78483
nosy: dontbugme
severity: normal
status: open
title: undesired switch fall-through in socketmodule.c

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com