[issue4856] Remove checks for win NT
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: The functions Py_GetFileAttributesExA and Py_GetFileAttributesExW were not removed. Is it intended? -- assignee: - ocean-city status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Oops, sorry. This function is not needed if GetFileAttributesEx never fail with ERROR_CALL_NOT_IMPLEMENTED. I believe this won't happen on win NT. How about this patch? -- Added file: http://bugs.python.org/file14381/remove_unused_function.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Yes, that's what I had in mind. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Thanks, committed in r73675(trunk) and r73676(py3k). -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Martin v. Löwis mar...@v.loewis.de added the comment: Sure, go ahead. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Thanks, committed in r73603(trunk) and r73604(py3k). -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: OK, 3.1 was out. Can I commit this to trunk and merge it to py3k? -- versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Here is an updated patch with Py_GetFileAttributesEx[AW] removal. I propose to commit this to trunk, and merge it to py3k after 3.1 will be released. -- Added file: http://bugs.python.org/file14327/remove_w9x_code.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Martin v. Löwis mar...@v.loewis.de added the comment: I think it's easier if the patch just sits here for six more days; 3.1 won't take much longer. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Martin v. Löwis mar...@v.loewis.de added the comment: The patch is slightly out of date; if updated, it is fine to apply after 3.1. I think Py_GetFileAttributesExA can also be removed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: +1. I've tested this patch on win2k vc6, and worked correctly. -- nosy: +ocean-city ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
New submission from Ulrich Eckhardt eckha...@satorlaser.com: There are several checks like GetVersion() 0x8000 that try to determine whether there is support for the WCHAR versions of the win32 API. Since all support for MS Windows 95, 98 and ME has been dropped, all supported systems support those APIs. Also, I need that cleanup as preparation for porting Python to MS Windows CE, so that I don't have to clone/port code for obsolete systems there. I'll be providing patches here. -- components: Interpreter Core messages: 79237 nosy: eckhardt severity: normal status: open title: Remove checks for win NT type: feature request versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: +1 -- nosy: +amaury.forgeotdarc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4856] Remove checks for win NT
Ulrich Eckhardt eckha...@satorlaser.com added the comment: This patch removes all calls to win32's GetVersion() where they are used to detect NT. In posixmodule.c it was used by a wrapper function that cached the result, which then also became obsolete. -- keywords: +patch Added file: http://bugs.python.org/file12618/python-2.7-win9x-wchar-checks.0.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4856 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
