[issue4949] Constness in PyErr_NewException

[Jeroen Demeyer]

Jeroen Demeyer added the comment:

Follow-up: #26476

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Andreas Kloeckner]

Andreas Kloeckner inf...@tiker.net added the comment:

ping?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Benjamin Peterson]

Benjamin Peterson benja...@python.org added the comment:

This patch is not applicable anymore to 3.x.

--
nosy: +benjamin.peterson
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

Assuming the patch doesn't cause warnings on the compilers that we use, it 
looks fine to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Andreas Kloeckner]

Andreas Kloeckner inf...@tiker.net added the comment:

ping?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Terry J. Reedy]

Terry J. Reedy tjre...@udel.edu added the comment:

Martin, do you agree with the premise of this issue?

The patch consists of adding 'const' in about 6 places in code and 
corresponding 6 places in capi doc.

--
keywords: +easy -patch
nosy: +loewis, tjreedy
versions: +Python 3.1, Python 3.2 -Python 2.5, Python 2.6, Python 3.0

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Andreas Kloeckner]

Changes by Andreas Kloeckner inf...@tiker.net:


--
versions: +Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Andreas Kloeckner]

New submission from Andreas Kloeckner inf...@tiker.net:

The name argument to PyErr_NewException() should be changed from char
* to const char *. Since the rest of pyerrors.h is const-correct,
this seems like an omission.

--
components: Interpreter Core
messages: 79868
nosy: inducer
severity: normal
status: open
title: Constness in PyErr_NewException
versions: Python 2.5, Python 2.6, Python 3.0

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Ulrich Eckhardt]

Ulrich Eckhardt eckha...@satorlaser.com added the comment:

It's not just that function, at least not in trunk. There are also 
PyErr_SetFromErrnoWithFilename, PyErr_SetFromErrnoWithUnicodeFilename 
and _PyErr_BadInternalCall which should be made const correct, see 
attached patch for trunk.

This patch also fixes some inconsistencies between the documentation 
and warning support functions.

--
keywords: +patch
nosy: +eckhardt
Added file: http://bugs.python.org/file12745/python-2.7-const-error.1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4949
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com