[issue4978] allow unicode keyword args

[Barry A. Warsaw]

Changes by Barry A. Warsaw :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Really trivial back port of r68805 from trunk.

--
assignee:  -> benjamin.peterson
components: +Interpreter Core -Library (Lib)
keywords: +needs review
resolution: accepted -> 
stage:  -> patch review
status: closed -> open
type: feature request -> behavior
versions: +Python 2.6
Added file: http://bugs.python.org/file16124/py26-backport.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

release blocker for 2.6.5

--
priority:  -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

Why backport? Isn't this a new feature?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Maybe not.  It's arguably a bug that adding unicode_literals breaks keyword 
arguments.  Guido seems to (mostly) agree that it's a bug we just never got 
around to fixing.

http://www.mail-archive.com/python-...@python.org/msg45346.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Done in r78027.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

New submission from Benjamin Peterson :

This allows unicode arguments to be passed as keywords to functions to
help "from __future__ import unicode_literals". See
http://mail.python.org/pipermail/python-dev/2009-January/085113.html.

--
components: Library (Lib)
messages: 80060
nosy: benjamin.peterson
severity: normal
status: open
title: allow unicode keyword args
type: feature request
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

Changes by Benjamin Peterson :


--
keywords: +patch
Added file: http://bugs.python.org/file12782/unicode_kwds.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

The patch works when the unicode contains only ascii, but crashes with
the following input:

>>> def f(hehe): return 42
... 
>>> f(**{u'hehe': 1})
42
>>> f(**{u'héhé': 1})
Segmentation fault

The two PyString_AsString(keyword) calls are now wrong and should be
changed.

--
nosy: +amaury.forgeotdarc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

Benjamin Peterson  added the comment:

This patch should fix that.

Added file: http://bugs.python.org/file12801/unicode_keyword_args.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

Sorry, but _PyUnicode_AsDefaultEncodedString returns either a borrowed 
reference (if 
errors==NULL) or a new reference (if errors!=NULL).
In either case it's wrong to DECREF the string when you simply take the 
buffer's 
address:

>>> f(**{u'someLongString':2})
Traceback (most recent call last):
  File "", line 1, in 
TypeError: f() got an unexpected keyword argument 'ÛÛÛgString'

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Interesting, I didn't know that about _PyUnicode_AsDefaultEncodedString.
Here's another patch.

Added file: http://bugs.python.org/file12805/unicode_kwargs3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

The patch looks good now.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4978] allow unicode keyword args

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Thanks for the reviews! Applied in r68805.

--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com