[issue5362] Add configure option to disable Py3k warnings

[Brett Cannon]

Changes by Brett Cannon :


--
resolution:  -> out of date
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

Since this issue doesn't apply in Python 3 and (as I understand it) the 2.7 
branch is only open to bug fixes, can we close this performance issue?

--
nosy: +stutzbach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Mark Lawrence]

Mark Lawrence  added the comment:

Both msg98465 and msg98466 agree that this should not be a configuration 
variable.  I think a new patch is needed which follows the suggested solutions 
from the two messages given.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

I'm with Antoine on this one.

Also, instead of removing the flag completely which will cause problems with 
extensions relying on it, I'd suggest to just disable the PyErr_WarnPy3k(msg, 
stacklevel) macro and turn it into a no-op if a compile time variable 
DISABLE_PY3K_WARNINGS (or similar) is defined (which should be undefined per 
default).

--
nosy: +lemburg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Given the very small benefits, I don't think there's any point in making this a 
configuration variable. A hardcoded flag would be sufficient, and expert users 
would be able to recompile their Python (as with the FAST_LOOPS flag).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Collin Winter]

Changes by Collin Winter :


Removed file: http://bugs.python.org/file13183/no_py3k_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Collin Winter]

Collin Winter  added the comment:

Bah, forgot to run autoreconf. Fixed.

Added file: http://bugs.python.org/file13184/no_py3k_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Collin Winter]

Changes by Collin Winter :


Removed file: http://bugs.python.org/file13168/no_py3k_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Collin Winter]

Collin Winter  added the comment:

Jeffrey: updated the patch to address your concerns.

Martin: I'm not sure I completely understand it either, though it seems
similar to issue4477. In the course of developing this patch, I tried
also #ifdef'ing out all usages of the Py_Py3kWarningFlag global. This
actually made things slower by around 5% across all the benchmarks I
tested. Could be pipeline stalls or a code size issue, I really don't know.

I'm not 100% convinced that something like this should go into CPython,
as a different compiler/hardware combination could well render it moot.
I mostly wanted a record of it, in case those few Python deployments
with homogeneous compilers/hardware across their machines that might
care about 1% better performance are interested.

Added file: http://bugs.python.org/file13183/no_py3k_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Jeffrey Yasskin]

Jeffrey Yasskin  added the comment:

s/Leaving/Turning/ in configure.in.

It looks like the convention for other --with flags that default to
enabled is to document them as --with(out)-xxx. (except tsc...) I guess
it's probably even better just to say what the default is in the
documentation.

"Trade away speed for Py3k compat warnings" is a bit harsh for a 1.5%
penalty. How about "Define to get Py3k compatibility warnings at the
cost of a little speed"?

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Martin v. Löwis]

Martin v. Löwis  added the comment:

I would like to understand the problem better first. I find it hard to
believe that mere access to a global (even if frequent) costs so much. I
think we should strive to make the warnings check faster if it indeed
produces significant runtime costs, rather than offering to remove it.

--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5362] Add configure option to disable Py3k warnings

[Collin Winter]

New submission from Collin Winter :

The attached patch adds a --with-py3k-warnings option to configure.
Passing --without-py3k-warnings disables all Py3k compatibility warnings
(the default is to keep the warnings). For production deployments where
performance is more important than warnings no-one will see, this can
provide a useful performance improvement:

2to3 (translate 2to3's source tree five times):
Min: 22.406 -> 22.114: 1.32% faster
Avg: 22.439 -> 22.158: 1.27% faster

Django (render a 150x150 table 100 times):
Min: 0.595 -> 0.586: 1.58% faster
Avg: 0.598 -> 0.588: 1.76% faster

Spitfire (render a 1000x1000 table 100 times):
Min: 0.752 -> 0.743: 1.29% faster
Avg: 0.754 -> 0.745: 1.25% faster

Unpickle (unpickling a list of 8000 dicts 100 times):
Min: 0.305 -> 0.301: 1.41% faster
Avg: 0.307 -> 0.302: 1.49% faster

Build env: gcc 4.3.1 x86_64 on Linux 2.6.18 (Core2 Duo)

--
assignee: jyasskin
components: Interpreter Core
files: no_py3k_warning.patch
keywords: needs review, patch, patch
messages: 82683
nosy: brett.cannon, collinwinter, jyasskin, pitrou
severity: normal
status: open
title: Add configure option to disable Py3k warnings
type: performance
versions: Python 2.7
Added file: http://bugs.python.org/file13168/no_py3k_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com