[issue5416] str.replace does strange things when given a negative count
Senthil Kumaran orsent...@gmail.com added the comment: Reverted the changes in r84626 (release27-maint), r84629(py3k), r84630 (release31-maint). - Minor doc clarification included wherein maxreplace is the argument instead of maxsplit in py27. - Also, did not bother to remove -1 in maxreplace. It is used as sentinel value for an optional argument. As it is not explicitly documented, the negative value for arg should not be relied upon. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Thank you. Please do the reversion and the docstring fixup. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: FWIW, we should be cautious about documenting all behaviors. It is arguable that this was an implementation detail and not a guaranteed behavior. As soon as you document it, people will rely on the API and all other implementations will need to change in order to comply. Please consider whether this doc change should be reverted. -- nosy: +rhettinger status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Senthil Kumaran orsent...@gmail.com added the comment: I am fine with your proposal, Raymond. When I went about the change the docstrings, I did notice that it is not an intentional feature to provide negative values in the replace argument. The negative value (-1 as count) was being used somewhat as a sentinel value to denote replace-all. I have no problem in reverting current documentation fix, but as a fix we can remove the existing reference of -1 in docstrings of str.replace so that it does not cause any confusing, which was the point of the original bug-report. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Senthil Kumaran orsent...@gmail.com added the comment: Fixed the doc string for release27-maint in revision r83879. py3k (r83880) and release31-maint in r83881. -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed type: feature request - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Terry J. Reedy tjre...@udel.edu added the comment: Changing to doc issue as two people suggested. Can anyone suggest new text to add? -- assignee: georg.brandl - d...@python components: +Documentation -Interpreter Core nosy: +d...@python, terry.reedy stage: unit test needed - needs patch versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Changes by Georg Brandl ge...@python.org: -- assignee: - georg.brandl nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
New submission from David Majnemer david.majne...@gmail.com: str.replace(, , asdf, -1) returns asdf, I believe this is not correct and strictly speaking not up to the documentation posted. I am of the opinion that it should function like str.replace(, , asdf, 0) which returns -- components: Interpreter Core messages: 83119 nosy: dmajnemer severity: normal status: open title: str.replace does strange things when given a negative count versions: Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Daniel Diniz aja...@gmail.com added the comment:
Confirmed in trunk and py3k. Changing to RFE, set it to behavior if you
disagree.
Python 2.4 does return for str.replace(, , asdf, -1), the
change happened in rev46226, with the effbot adding this snippet (by
Andrew Dalke?):
if (maxcount 0) {
maxcount = PY_SSIZE_T_MAX;
} else if (maxcount == 0 || PyString_GET_SIZE(self) == 0) {
/* nothing to do; return the original string */
return return_self(self);
}
I'm not sure the current behavior can be considered better than what
David proposes, but I also wonder whether it matters at all.
--
nosy: +ajaksu2
stage: - test needed
type: - feature request
versions: +Python 2.7, Python 3.1 -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5416
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
Senthil orsent...@gmail.com added the comment: And also look at the help on string.replace which sets -1 as the default value for maxsplit optional argument and which again defaults to replace-all. Clearly, maxsplit= -1 is not equal to maxsplit = 0. replace(s, old, new, maxsplit=-1) replace (str, old, new[, maxsplit]) - string Return a copy of string str with all occurrences of substring old replaced by new. If the optional argument maxsplit is given, only the first maxsplit occurrences are replaced. - Daniel, thanks for digging this out from Py2.4, unless we get an rationale behind this change, my only though on this issue was - document the maxsplit argument saying that -1 defaults to replace all. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5416] str.replace does strange things when given a negative count
David W. Lambert lamber...@corning.com added the comment: I completely agree that this is a documentation issue. Also, or perhaps for foolish completeness, in http://docs.python.org/3.0/library/stdtypes.html we would point out that the following group of string methods also work for bytes and bytearrays. Of these, only str type has format method. String Methods String objects support the methods listed below. Note that none of these methods take keyword arguments. In addition, Python’s strings support the sequence type methods described in the Sequence Types — str, bytes, bytearray, list, tuple, range section. To output formatted strings, see the String Formatting section. Also, see the re module for string functions based on regular expressions. -- nosy: +LambertDW ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5416 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
