[issue5420] Queue deprecation warning patch
Raymond Hettinger added the comment: Martin von Löwis successfully lobbied to keep these methods. -- resolution: - rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Stéphane Wirtel added the comment: No news for 2 years. -- nosy: +matrixise ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Éric Araujo mer...@netwok.org added the comment: I think the docstrings of empty and full should mention they’re obsolete, to make users of pydoc or other tools aware of the deprecation before they write code using them. -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Benjamin Peterson benja...@python.org added the comment: It's too late now for deprecation in 3.2... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Tennessee Leeuwenburg tleeuwenb...@gmail.com added the comment: Patch covering all files in a single patch. * Updated warning message * Updated multiprocessing tests to avoid calls to empty and full * Placed deprecation warning in multiprocessing methods * Update wsgui to avoid deprecated calls Issues: * Noticed no warnings raised as a result of changes to multiprocessing: ergo multiprocessing.queue empty() and full() methods are not currently getting test coverage * No obvious test rig for wsgui, so code is completely untested (!), but I figured someone closer to wsgui could at least have my code for reference, so included in the patch Added file: http://bugs.python.org/file13251/queue_patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Tennessee Leeuwenburg tleeuwenb...@gmail.com added the comment: Hi JP, I experimented with stacklevel but to be honest nothing I saw appeared greatly more useful than the default for the tests in question. What form would the unit tests take? Trying to assert that empty() and full() raised a deprecation warning? I'm not sure how I would go about that, but I'll see what I can do. Thanks, -Tennessee On Thu, Mar 5, 2009 at 3:00 PM, Jean-Paul Calderone rep...@bugs.python.orgwrote: Jean-Paul Calderone exar...@divmod.com added the comment: Unit tests are a great thing as well. Also, the deprecation warnings you've added are the really annoying kind. They refer to users to the source of the deprecated methods themselves! A vastly preferable use of the warnings system is to refer users to the *callers* of the deprecated methods. Try passing different values for the stacklevel parameter of the warnings.warn function until you get a warning that is more helpful. -- nosy: +exarkun ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ Added file: http://bugs.python.org/file13252/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___Hi JP,brbrI experimented with stacklevel but to be honest nothing I saw appeared greatly more useful than the default for the tests in question.brbrWhat form would the unit tests take? Trying to assert that empty() and full() raised a deprecation warning? I#39;m not sure how I would go about that, but I#39;ll see what I can do.br brThanks,br-Tennesseebrbrdiv class=gmail_quoteOn Thu, Mar 5, 2009 at 3:00 PM, Jean-Paul Calderone span dir=ltrlt;a href=mailto:rep...@bugs.python.org;rep...@bugs.python.org/agt;/span wrote:brblockquote class=gmail_quote style=border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex; br Jean-Paul Calderone lt;a href=mailto:exar...@divmod.com;exar...@divmod.com/agt; added the comment:br br Unit tests are a great thing as well. Â Also, the deprecation warningsbr you#39;ve added are the really annoying kind. Â They refer to users to thebr source of the deprecated methods themselves! Â A vastly preferable use ofbr the warnings system is to refer users to the *callers* of the deprecatedbr methods. Â Try passing different values for the stacklevel parameter ofbr the warnings.warn function until you get a warning that is more helpful.br br --br nosy: +exarkunbr divdiv/divdiv class=h5br ___br Python tracker lt;a href=mailto:rep...@bugs.python.org;rep...@bugs.python.org/agt;br lt;a href=http://bugs.python.org/issue5420; target=_blankhttp://bugs.python.org/issue5420/agt;br ___br /div/div/blockquote/divbrbr clear=allbr-- br--brTennessee Leeuwenburgbra href=http://myownhat.blogspot.com/;http://myownhat.blogspot.com//abrquot;Don#39;t believe everything you thinkquot;br ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- assignee: rhettinger - benjamin.peterson nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Changes by Tennessee Leeuwenburg tleeuwenb...@gmail.com: Removed file: http://bugs.python.org/file13252/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Changes by Jesse Noller jnol...@gmail.com: -- nosy: +jnoller ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Jesse Noller jnol...@gmail.com added the comment: Quote: Issues: * Noticed no warnings raised as a result of changes to multiprocessing: ergo multiprocessing.queue empty() and full() methods are not currently getting test coverage ? I need to check this. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Benjamin Peterson benja...@python.org added the comment: You should test that the warnings are given by the deprecated methods. Look at test_py3kwarn for an example of how to do that. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Tennessee Leeuwenburg tleeuwenb...@gmail.com added the comment: Now, with unit tests... :) Added file: http://bugs.python.org/file13253/queue_patch3.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
New submission from Tennessee Leeuwenburg tleeuwenb...@gmail.com: A very tiny patch which places a DeprecationWarning inside Queue.empty and Queue.full -- components: Library (Lib) files: queue_patch.txt messages: 83180 nosy: tleeuwenb...@gmail.com severity: normal status: open title: Queue deprecation warning patch type: feature request versions: Python 3.1 Added file: http://bugs.python.org/file13245/queue_patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Tennessee Leeuwenburg tleeuwenb...@gmail.com added the comment: Add comment to NEWS as documented... Added file: http://bugs.python.org/file13246/NEWS_patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Can you make a single patch for Lib/queue.py and Misc/NEWS and remove any uses of emtpy/full in the standard library including multiprocessing. Also, for deprecations, it's always nice to have the message suggest an alternative, something like: The empty() method is deprecated and scheduled to be removed in Py3.2. Instead, use qsize() or catch a queue.Empty exception. -- assignee: - rhettinger nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Jean-Paul Calderone exar...@divmod.com added the comment: Unit tests are a great thing as well. Also, the deprecation warnings you've added are the really annoying kind. They refer to users to the source of the deprecated methods themselves! A vastly preferable use of the warnings system is to refer users to the *callers* of the deprecated methods. Try passing different values for the stacklevel parameter of the warnings.warn function until you get a warning that is more helpful. -- nosy: +exarkun ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5420] Queue deprecation warning patch
Changes by David W. Lambert lamber...@corning.com: -- nosy: +LambertDW ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5420 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
