[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.6, Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Julien Palard]

Julien Palard  added the comment:

It looks like a revert of 47404f3e36699786082d0ee6565872d627e1
Which is the fix for https://bugs.python.org/issue723962 which I'm currently 
reading.

--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Natal Ngétal]

Change by Natal Ngétal :


--
pull_requests: +10141
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I'm not sure if this is a 2.6/2.7 only issue because the code mentioned in 
msg86572 still exists, although with a change for #21800 (RFC 6855/UTF-8) 
applied.

For reference, #25591 expanded the test coverage for the imaplib.  However, I 
don't see any tests related to CR or LF in literals.

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Matej Cepl]

Matej Cepl  added the comment:

Oh, this is 2.6 bug. This should be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Matej Cepl]

Matej Cepl  added the comment:

> Module imaplib has pretty sparse test code.

On that note: would anybody be willing to express in form of (simplified) test 
case, what's the problem reported here? I am not sure, I follow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Matej Cepl]

Change by Matej Cepl :


--
nosy: +mcepl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[R. David Murray]

Changes by R. David Murray :


--
components: +email
nosy: +barry, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Rajesh S R]

Rajesh S R  added the comment:

Am quite new here; just searching hard to contribute, would like to
patch this, if I can go ahead.

Don't we need to patch the original imaplib code also?

just remove the line:
self.literal = MapCRLF.sub(CRLF, message)
and have:
self.literal = message
Or am I missing something completely?

--
nosy: +rajeshsr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Ron DuPlain]

Ron DuPlain  added the comment:

Module imaplib has pretty sparse test code.  There is only 1 test case,
for imaplib.Time2Internaldate.
trunk/Lib/test/test_imaplib.py

The attached patch tests for LF, CR preservation with regard to the
IMAP4.append method, but more testing is necessary to make sure LF, CR
are preserved in IMAP literals throughout imaplib and that the
respective fix doesn't break anything.  Mock IMAP interaction may be the
way to go for better test cases.  Is anyone working on expanding imaplib
test coverage?

-Ron

--
keywords: +patch
versions: +Python 2.7
Added file: http://bugs.python.org/file13789/test_imaplib_cr_lf.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Ron DuPlain]

Ron DuPlain  added the comment:

It looks like the IMAP4.append method is responsible for the CRLF
substitution (trunk/Lib/imaplib.py).

# defined near top of module:
MapCRLF = re.compile(r'\r\n|\r|\n')

# in append method:
self.literal = MapCRLF.sub(CRLF, message)

I'll work on a test for it this evening.

-Ron

--
nosy: +ron.duplain

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Daniel Diniz]

Changes by Daniel Diniz :


--
keywords: +easy
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5430] imaplib: must not replace LF or CR by CRLF in literals

[Memeplex]

Changes by Memeplex :


--
title: Must not replace LF or CR by CRLF in literals -> imaplib: must not 
replace LF or CR by CRLF in literals

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com