[issue5571] new "TestCase.skip" method causes all tests to skip under trial (Twisted's test runner)

[Glyph Lefkowitz]

Glyph Lefkowitz  added the comment:

I went to the trouble of tracking it down and then I forgot to attach a
comment: I'm pretty sure Benjamin meant r70616.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5571] new "TestCase.skip" method causes all tests to skip under trial (Twisted's test runner)

[Jean-Paul Calderone]

Jean-Paul Calderone  added the comment:

Hi Benjamin,

Thanks for this fix. :)  I noticed the revision in your comment doesn't
seem to be the one that contains the fix though.

--
nosy: +exarkun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5571] new "TestCase.skip" method causes all tests to skip under trial (Twisted's test runner)

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Renamed to skipTest in r60616.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5571] new "TestCase.skip" method causes all tests to skip under trial (Twisted's test runner)

[Glyph Lefkowitz]

New submission from Glyph Lefkowitz :

c.f. this Twisted ticket: http://twistedmatrix.com/trac/ticket/3703

Twisted's test tool has an extended TestCase which uses the 'skip'
attribute, on both tests and methods, to determine whether to skip them.
 You can see the implementation here:

http://twistedmatrix.com/trac/browser/trunk/twisted/trial/unittest.py?rev=26043#L655

The addition of the new 'skip' method in unittest.py therefore causes
trial, twisted's test tool, to unconditionally skip all tests.

I've set the priority to release blocker because I'd like it to be
determined whether this is really python's fault, or twisted's fault for
subclassing TestCase.

If the new 'skip' method of TestCase is renamed to something else, say
skipTest, this won't be a problem.

While I understand that this is technically a compatible change (the
addition of an attribute) I'd appreciate it if this changed on Python's
side of things, because leaving it up to Twisted means we need to go
through a deprecation cycle on a long-standing, stable public interface
that a lot of test code is using.

--
assignee: benjamin.peterson
components: Library (Lib)
messages: 84198
nosy: benjamin.peterson, glyph
priority: release blocker
severity: normal
status: open
title: new "TestCase.skip" method causes all tests to skip under trial 
(Twisted's test runner)
type: behavior
versions: Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com