[issue5664] 2to3 wont convert Cookie.Cookie properly

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed
superseder:  -> Close 2to3 issues and list them here

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Aldwin Pollefeyt]

Change by Aldwin Pollefeyt :


--
nosy: +aldwinaldwin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Aldwin Pollefeyt]

Change by Aldwin Pollefeyt :


--
keywords: +patch
pull_requests: +14990
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15268

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Senthil Kumaran]

Senthil Kumaran added the comment:

Not actually, It is still translating to http.cookies.Cookie - which does not 
exist.

$ ./cpythonvenv/bin/2to3-3.4 bug-fixes/test1.py
RefactoringTool: Refactored bug-fixes/test1.py
--- bug-fixes/test1.py  (original)
+++ bug-fixes/test1.py  (refactored)
@@ -1,2 +1,2 @@
-import Cookie
-c = Cookie.Cookie('abc')
+import http.cookies
+c = http.cookies.Cookie('abc')

BTW, Cookie.Cookie is a deprecated interface so there is a possibility that 
only small portion of the real world code which has not updated their Python 
stdlib idioms since (Python 2.2/Python2.4?) would see this bug manifested.

[Note: Long-time users of Cookie.py will remember using
Cookie.Cookie() to create an Cookie object.  Although deprecated, it
is still supported by the code.  See the Backward Compatibility notes
for more information.]

--
versions: +Python 3.4 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Mark Lawrence]

Mark Lawrence added the comment:

I'm assuming msg98615 is correct so this can be closed.

--
nosy: +BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Meador Inge]

Meador Inge  added the comment:

There is already a fixer for this in 'Lib/lib2to3/fixes/fix_imports.py'.  It 
was merged to the trunk in r64286.

--
nosy: +minge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Benjamin Peterson]

Benjamin Peterson  added the comment:

2009/4/1 Senthil :
>
> New submission from Senthil :
>
> In 2.7 code have:
> import Cookie
> c = Cookie.Cookie('abc')
>
> 2to3 would do:
> c = http.cookies.Cookie('abc')
>
> This is wrong as there is no class as Cookie in http.cookies. It should
> translated to be http.cookies.SimpleCookie.

That's unfortunate. I suppose a new custom fixer will have to be
written for Cookie now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5664] 2to3 wont convert Cookie.Cookie properly

[Senthil]

New submission from Senthil :

In 2.7 code have:
import Cookie
c = Cookie.Cookie('abc')

2to3 would do:
c = http.cookies.Cookie('abc')

This is wrong as there is no class as Cookie in http.cookies. It should
translated to be http.cookies.SimpleCookie.

--
assignee: benjamin.peterson
components: 2to3 (2.x to 3.0 conversion tool)
messages: 85151
nosy: benjamin.peterson, orsenthil
severity: normal
status: open
title: 2to3 wont convert Cookie.Cookie properly
type: behavior
versions: Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com