[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
pull_requests: +7099

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

Change by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

INADA Naoki  added the comment:


New changeset d59f97c8325ba509c9b08d488091f45ca642f0b6 by INADA Naoki in branch 
'3.6':
bpo-5755: Move -Wstrict-prototypes to CFLAGS_NODIST (GH-7395)
https://github.com/python/cpython/commit/d59f97c8325ba509c9b08d488091f45ca642f0b6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +7065

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[miss-islington]

miss-islington  added the comment:


New changeset d6e789c402330905b1bd9103538d1027fcfb08a4 by Miss Islington (bot) 
in branch '3.7':
bpo-5755: Move -Wstrict-prototypes to CFLAGS_NODIST (GH-7395)
https://github.com/python/cpython/commit/d6e789c402330905b1bd9103538d1027fcfb08a4


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[miss-islington]

Change by miss-islington :


--
pull_requests: +7047

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

INADA Naoki  added the comment:


New changeset e33648484775fa533fc8f1e5cc45f60061d29d54 by INADA Naoki in branch 
'master':
bpo-5755: Move -Wstrict-prototypes to CFLAGS_NODIST (GH-7395)
https://github.com/python/cpython/commit/e33648484775fa533fc8f1e5cc45f60061d29d54


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> 2.7 doesn't have CFLAGS_NODIST

I meant backporting this patch as-is to 2.7 without adding -Wstrict-prototypes 
to CFLAGS_NODIST

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

INADA Naoki  added the comment:

2.7 doesn't have CFLAGS_NODIST and I don't have motivation to manually backport 
it to 2.7.  (I'm not expert of autotools)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> Can we backport this to 3.7 and 3.6?  I think it's safe and helpful.

And 2.7 for the same reasons.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +7021

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

INADA Naoki  added the comment:

-Wstrict-prototypes is not included in -Wall and -Wextra.
I created PR-7395 which moves the option to CFLAGS_NODIST, as Serhiy suggested 
before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I am not sure now about removing -Wstrict-prototypes. I haven't found 
confirmation that this option is included in -Wall or -Wextra.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[INADA Naoki]

INADA Naoki  added the comment:

Can we backport this to 3.7 and 3.6?  I think it's safe and helpful.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Eitan Adler]

Eitan Adler  added the comment:

copying and adapting my comments on the PR:

Strict Prototypes is correct and helpful for C. That said, the way it is 
currently implemented, by checking for the compiler in CC is sub-optimal at 
best.
CC ought to always be a C compiler, and never a C++ compiler.
It also seems questionable that distutils is using the python cflags rather 
than a dedicated set.

The best fix is a separate and specific list of flags for distutils rather than 
modifying the set of flags used to build python. That said, the current 
implementing of flags for python isn't great, so lets remove it as a short term 
fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Eitan Adler]

Change by Eitan Adler :


--
nosy: +eitan.adler

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> Or just remove it

I updated the PR to do that.

I didn't want to propose that initially because that patch was proposed here 
almost 2 years ago but not accepted.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Maybe include it in PY_CFLAGS_NODIST instead of PY_CFLAGS? Or just remove it, 
since in any case we now use -Wall and -Wextra with GCC.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
pull_requests: +6476
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

[Jeroen Demeyer]

Changes by Jeroen Demeyer :


--
keywords: +patch
Added file: http://bugs.python.org/file44464/no_strict_proto.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Jon Parise]

Changes by Jon Parise j...@indelible.org:


--
nosy:  -jon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Peter Le Bek]

Peter Le Bek pe...@hyperplex.net added the comment:

distutils reuses whatever flags Python was built with, covered here: 
http://bugs.python.org/issue1222585 (and here http://bugs.python.org/issue9031).

--
nosy: +vokoda

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Jon Parise]

Changes by Jon Parise j...@indelible.org:


--
nosy: +jon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Andy Bailey]

Changes by Andy Bailey goosey...@gmail.com:


--
nosy: +GooseYArd

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Jason Grout]

Jason Grout jason.gr...@drake.edu added the comment:

Any progress on this?  I see this warning a *lot* when compiling lots of 
packages for Sage (matplotlib included).

--
nosy: +Jason.Grout

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Tarek Ziadé]

Tarek Ziadé ziade.ta...@gmail.com added the comment:

I could work on a patch for this, by checking the compiler, if I get
some feedback from the matplotlib guys in this issue here

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5755] -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

[Zooko O'Whielacronx]

New submission from Zooko O'Whielacronx zo...@zooko.com:

A user of the Tahoe-LAFS project submitted a bug report to us, saying:


I get lots of cc1plus: warning: command line option -Wstrict-
prototypes is valid for Ada/C/ObjC but not for C++ when compiling


A little googling shows that this gets reported frequently to other 
Python projects that have C++ code:

http://trac.sagemath.org/sage_trac/ticket/425
http://www.mail-archive.com/matplotlib-
us...@lists.sourceforge.net/msg03947.html

Those other projects seem to think that this is distutils's problem, but 
I don't see evidence that any of them opened a ticket for distutils yet.

--
assignee: tarek
components: Distutils
messages: 85972
nosy: tarek, zooko
severity: normal
status: open
title: -Wstrict-prototypes is valid for Ada/C/ObjC but not for C++

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5755
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com