[issue5761] add file name to py3k IO objects repr()

[R. David Murray]

R. David Murray  added the comment:

Antoine, by "reused for f's repr" do you mean adding 'name=' into
the existing repr (probably before the encoding)?

Benjamin, by "bytes" do you mean BytesIO objects?  Would it be
acceptible to give them a 'name' attribute set to 'None'?

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Antoine, by "reused for f's repr" do you mean adding 'name=' into
> the existing repr (probably before the encoding)?

Exactly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Here is a patch.

--
keywords: +patch
Added file: http://bugs.python.org/file14044/issue5761.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Antoine Pitrou  added the comment:

New patch following Benjamin's comments.

--
Added file: http://bugs.python.org/file14046/issue5761-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Committed in r72870.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

New submission from Antoine Pitrou :

>>> f = open("py3k/__svn__/LICENSE")
>>> f

>>> f.buffer
<_io.BufferedReader object at 0x7f4b67569f68>
>>> f.buffer.raw
io.FileIO(3, 'rb')
>>> f.name
'py3k/__svn__/LICENSE'

It would probably be nice if f.name were reused for f's repr().

--
components: Library (Lib)
messages: 85989
nosy: benjamin.peterson, pitrou
priority: normal
severity: normal
stage: test needed
status: open
title: add file name to py3k IO objects repr()
type: feature request
versions: Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Benjamin Peterson]

Benjamin Peterson  added the comment:

What should we do about filenames of bytes?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Benjamin, do you think it can still be added after beta1?
(I ask that in case noone does it before)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Benjamin Peterson]

Benjamin Peterson  added the comment:

2009/4/21 Antoine Pitrou :
>
> Antoine Pitrou  added the comment:
>
> Benjamin, do you think it can still be added after beta1?
> (I ask that in case noone does it before)

Yes, I think that would be ok.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5761] add file name to py3k IO objects repr()

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
components: +IO

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com