[issue6031] BaseServer.shutdown documentation is incomplete
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 4fad6b811c8b by Sandro Tosi in branch '2.7': Issue #6031: improve serve_forever() description http://hg.python.org/cpython/rev/4fad6b811c8b New changeset 4a30d36a9c69 by Sandro Tosi in branch '3.2': Issue #6031: improve serve_forever() description http://hg.python.org/cpython/rev/4a30d36a9c69 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
Sandro Tosi sandro.t...@gmail.com added the comment: yep indeed, I've removed the deadlock part and committed. -- resolution: - fixed stage: - committed/rejected status: open - closed versions: +Python 3.3 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
R. David Murray rdmur...@bitdance.com added the comment: Hmm. It seems as though since issue 2302 is now closed, the comment about deadlocking if called before serve_forever may no longer be true. Gabriel? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
Changes by R. David Murray rdmur...@bitdance.com: -- versions: -Python 2.6, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
Sandro Tosi sandro.t...@gmail.com added the comment: Hello, I've refreshed this patch (correct the file name because it applies now with an offset), other than that it seems ok: can someone review (it's quite small :) and apply it? Thanks, Sandro -- nosy: +sandro.tosi Added file: http://bugs.python.org/file19022/issue6031-py3k-v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
Gabriel Genellina gagsl-...@yahoo.com.ar added the comment: Documentation patch for BaseServer.server_forever() and shutdown() -- keywords: +patch Added file: http://bugs.python.org/file15342/socketserver.rst.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6031] BaseServer.shutdown documentation is incomplete
New submission from Gabriel Genellina gagsl-...@yahoo.com.ar: BaseServer.shutdown is documented as Tells the serve_forever() loop to stop and waits until it does. The docstring is much more explicit: Stops the serve_forever loop. Blocks until the loop has finished. This must be called while serve_forever() is running in another thread, or it will deadlock. Combined with #2302 I'd rewrite both (rst and docstring) as: BaseServer.shutdown(): Tells the serve_forever() loop to stop, and waits until the loop has finished. This must be called after serve_forever() has started and while it is running in another thread, or the shutdown() call will deadlock. -- assignee: georg.brandl components: Documentation messages: 87845 nosy: gagenellina, georg.brandl severity: normal status: open title: BaseServer.shutdown documentation is incomplete type: behavior versions: Python 2.6, Python 2.7, Python 3.0, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6031 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
