[issue6042] Document and slightly simplify lnotab tracing

[Jeffrey Yasskin]

New submission from Jeffrey Yasskin :

lnotab-based tracing is very complicated and isn't documented very well.
There were at least 3 comment blocks purporting to document co_lnotab,
and none did a very good job. This patch unifies them into
Objects/lnotab_notes.txt which tries to completely capture the current
state of affairs.  I'm posting this here so that people can check that I
got it right. Thanks!

I also discovered that we've attached 2 layers of patches to the basic
tracing scheme. The first layer avoids jumping to instructions that
don't start a line, to avoid problems in if statements and while loops.
The second layer discovered that jumps backward do need to trace at
instructions that don't start a line, so it added extra lnotab entries
for 'while' and 'for' loops, and added a special case for backward jumps
within the same line. I replaced these patches by treating forward and
backward jumps differently.

I could simplify this slightly more by changing PyCode_CheckLineNumber.
 It doesn't appear to be used outside of the core, but since it doesn't
start with an _, I want to double-check that changing its interface is ok.

--
components: Interpreter Core
files: lnotab.patch
keywords: needs review, patch
messages: 87919
nosy: jyasskin
severity: normal
stage: patch review
status: open
title: Document and slightly simplify lnotab tracing
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file13996/lnotab.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Collin Winter]

Changes by Collin Winter :


--
nosy: +collinwinter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Georg Brandl]

Georg Brandl  added the comment:

Jeffrey, while you're at lnotab stuff, could you have a look at #1689458
as well?

--
nosy: +georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I can't say anything about the simplification since I never use tracing,
but +1 at least on the doc cleanup.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Jeffrey Yasskin]

Jeffrey Yasskin  added the comment:

I've fixed #1689458. Here's a new version of the patch with the
simplifying tweaks to PyCode_CheckLineNumber() so y'all can see what
that looks like.

If I don't get any substantive comments by the weekend (thanks Antoine
for the docs +1 :), I'll assume I've looked at this code longer than
anyone in the last 7 years and commit it. :)

--
Added file: http://bugs.python.org/file14038/lnotab.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I'm not sure why you changed PyCode_CheckLineNumber to
_PyCode_CheckLineNumber. Other than that, I suppose you know what you're
doing :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Jeffrey Yasskin]

Jeffrey Yasskin  added the comment:

I had two reasons to change PyCode_CheckLineNumber to
_PyCode_CheckLineNumber: First, its behavior is changing without its
signature changing. Without a name change, that could break users
silently (if there are any codesearch missed). Second, I think it's an
internal function which we should feel free to change again if it makes
the implementation cleaner. In order to let people change it at will, it
should start with "_Py".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Jeffrey Yasskin]

Jeffrey Yasskin  added the comment:

Committed to trunk in r72879. I'll wait to merge it to 3.x until 3.1 has
been released, since we're approaching the release candidate there.

--
stage: patch review -> committed/rejected

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Jeffrey Yasskin]

Changes by Jeffrey Yasskin :


--
assignee:  -> jyasskin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6042] Document and slightly simplify lnotab tracing

[Alexandre Vassalotti]

Alexandre Vassalotti  added the comment:

The patch was merged to 3.x in r74132.

--
assignee: jyasskin -> 
nosy: +alexandre.vassalotti
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com