[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

Thank you!

On Fri, Feb 25, 2011 at 2:08 PM, Antoine Pitrou  wrote:
>
> Antoine Pitrou  added the comment:
>
> I corrected the patches (they were breaking the property of inheriting daemon 
> by default) and committed them in r88618. Thank you!
>
> --
> resolution:  -> fixed
> stage: patch review -> committed/rejected
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I corrected the patches (they were breaking the property of inheriting daemon 
by default) and committed them in r88618. Thank you!

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
assignee: jnoller -> 
stage:  -> patch review
type: behavior -> feature request
versions: +Python 3.3 -Python 2.7, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Brian Brazil]

Brian Brazil  added the comment:

Looks like it lost my patch, but Steven's does the same.

One tweak: in threading.rst put all of the class signature on one line or the 
html formatting will be a bit off.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Brian Brazil]

Brian Brazil  added the comment:

I've updated the patch for 3.2 and improved the documentation formatting.

--
nosy: +bbrazil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Steven Alderson]

Steven Alderson  added the comment:

Here's the patch for multiprocessing based on python 3 revision 83065, all 
credit to the original author, all problems probably mine!
Steven

--
Added file: http://bugs.python.org/file18153/multiprocessing3k.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Steven Alderson]

Steven Alderson  added the comment:

Hello, I've taken the liberty of updating the two patch files here for 
python3.2 at revision 83065.  Apologies if I'm treading on anyones toes here.  
I'm taking part in a europython sprint and this is the first time I've tried 
this.

I've modified the multiprocessing patch.  The documentation didn't agree with 
the behaviour of the code, so I've changed the Doc file.  I've also added an 
extra test for the default behaviour.

I've reviewed the code for PEP 8 (as an exercise for me) and run the tests and 
they passed ok.

Steven

--
nosy: +steven
type: feature request -> behavior
Added file: http://bugs.python.org/file18152/threading3k.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Ask Solem]

Ask Solem  added the comment:

Patch for multiprocessing, adding the daemon kwarg attached.

--
nosy: +asksol
Added file: 
http://bugs.python.org/file15376/6064-multiprocessing-daemon-kwarg.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Jesse Noller]

Changes by Jesse Noller :


--
assignee:  -> jnoller

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Jesse Noller]

Jesse Noller  added the comment:

+1 to this, and I'd need to make the same patch/change to 
multiprocessing.Process as well

--
nosy: +jnoller

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Antoine Pitrou]

Antoine Pitrou  added the comment:

+1 from me as well.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Pablo Torres Navarrete]

Pablo Torres Navarrete  added the comment:

+1 on making it a keyword-only argument.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Lucas Prado Melo]

Lucas Prado Melo  added the comment:

+1 to the py3k diff. :)
Hey, I think this daemon property should be set as a keyword argument of
the Thread constructor.

--
nosy: +conf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Pablo Torres Navarrete]

Pablo Torres Navarrete  added the comment:

> I'm diffing against the 2.7 branch, I guess your comes from the 3.2?
*forehead meets desktop*

Patch applies cleanly and all tests pass.  I used it for a while and 
everything seemed OK.  After someone else tests, I say we go for it :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

Attaching a diff against the py3k branch on revision 73468

--
Added file: http://bugs.python.org/file14314/threading3k.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

I'm diffing against the 2.7 branch, I guess your comes from the 3.2?

Will checkout 3.2 and do it there as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Pablo Torres Navarrete]

Pablo Torres Navarrete  added the comment:

Nope.  Our working copies seem to be different.  I'm uploading mine, 
which I just update to revision 73468.  Please diff yours against that 
and against HEAD too, just in case.

Hunk 2 on threading.py fails because your attributes use two leading 
underscores and mine use only one.  I have no idea why hunk4 fails.

--
Added file: http://bugs.python.org/file14313/threading.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

I'm attaching a new diff (svn diff > threading.diff), hope this one's OK.

--
Added file: http://bugs.python.org/file14312/threading.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Pablo Torres Navarrete]

Pablo Torres Navarrete  added the comment:

+1, but I can't apply the patch cleanly:

$ patch -p0 < threading.diff
patching file Doc/library/threading.rst
Hunk #1 succeeded at 198 (offset -17 lines).
Hunk #2 succeeded at 211 (offset -17 lines).
Hunk #3 succeeded at 230 (offset -17 lines).
patching file Lib/threading.py
Hunk #1 succeeded at 407 with fuzz 1 (offset -16 lines).
Hunk #2 FAILED at 416.
1 out of 2 hunks FAILED -- saving rejects to file Lib/threading.py.rej
patching file Lib/test/test_threading.py
Hunk #1 succeeded at 350 with fuzz 2 (offset 14 lines).

--
nosy: +ptn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

I think that 
self.__daemonic = daemon or self._set_daemon()
is wrong, need to thing about it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

Miki Tebeka  added the comment:

Attaching a patch against trunk (at revision 72805).

--
keywords: +patch
Added file: http://bugs.python.org/file14029/threading.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Amaury Forgeot d'Arc]

Changes by Amaury Forgeot d'Arc :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Raymond Hettinger]

Raymond Hettinger  added the comment:

+1

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6064] Add "daemon" argument to threading.Thread constructor

[Miki Tebeka]

New submission from Miki Tebeka :

It would be nice if threading.Thread constructor will have a "daemon"
argument as well.

This way we'll be able to write
Thread(target=some_function, daemon=1).start()

Instead of currently writing
t = Thread(target=some_function)
t.daemon = True
t.start()

--
components: Library (Lib)
messages: 88088
nosy: tebeka
severity: normal
status: open
title: Add "daemon" argument to threading.Thread constructor
type: feature request
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com