[issue6131] test_modulefinder leaks when run after test_distutils
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I can reproduce refleaks with only test_distutils now. E:\python-dev\py3k\Lib\testpy3k regrtest.py -R3:2: test_distutils test_distutils beginning 5 repetitions 12345 . test_distutils leaked [280, 280] references, sum=560 1 test failed: test_distutils I think this refleaks can be solved by using super() for setUp() and tearDown() everywhere. -- Added file: http://bugs.python.org/file14109/fix_distutils_refleak.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Tarek Ziadé ziade.ta...@gmail.com added the comment: Thanks, it fixed it. Applied in the trunk. Can you guys merge r73008 into Py3k please ? I have a problem today, I can't build py3k on Mac OS X anymore, I am trying to figure out why. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Done in r73010. I think it would be better to patch release26maint.patch for release26-maint (and same patch for release30-maint) to complete super() issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: Added file: http://bugs.python.org/file14110/release26maint.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Tarek Ziadé ziade.ta...@gmail.com added the comment: done thx for the help. Do you happen to know the exact reason why using super rather than an explicit call avoids the leaking ? -- status: open - closed versions: +Python 2.6, Python 2.7, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Well, I don't know... But probably mixing super() and non super() caused too many call of setUp() or tearDown(). I saw such case before. To track down this, probably this info helps. 1. Revert to previous revision of distutils 2. Remove distutils tests except for test_archive_util.py and test_bdist_dumb.py 3. Run regrtest.py -R2:3: test_distutils test_distutils beginning 5 repetitions 12345 . test_distutils leaked [280, 280] references, sum=560 1 test failed: test_distutils -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I tracked down more deeper. LoggingSilencer.setUp() was called twice, so restoration of log.Log._log was not done correctly. log.Log._log becomes method of TestCase class after test done in most cases. Probably this keeps reference to TestCase and its instance variables. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Tarek Ziadé ziade.ta...@gmail.com added the comment: If I remove distutils.tests.test_config , the leak dissapears. I don't understand why yet. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
New submission from Antoine Pitrou pit...@free.fr: When run independently, test_modulefinder doesn't leak: $ ./python -m test.regrtest -R 3:2 test_modulefinder test_modulefinder beginning 5 repetitions 12345 . 1 test OK. [93448 refs] But it does leak if test_distutils was run before it: $ ./python -m test.regrtest -R 3:2 test_distutils test_modulefinder test_distutils [31861 refs] beginning 5 repetitions 12345 [31861 refs] .[31861 refs] .[31861 refs] .[31861 refs] .[31861 refs] . test_modulefinder beginning 5 repetitions 12345 . test_modulefinder leaked [145, 145] references, sum=290 The fact that test_modulefinder uses distutils.dir_util could have something to do with this? -- components: Library (Lib), Tests messages: 88449 nosy: pitrou, tarek priority: normal severity: normal status: open title: test_modulefinder leaks when run after test_distutils type: resource usage versions: Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6131] test_modulefinder leaks when run after test_distutils
Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: Here is workaround for reference leak. I'm not sure what exactly leaks references yet. -- keywords: +patch nosy: +ocean-city Added file: http://bugs.python.org/file14103/workaround.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6131 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
