[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

New submission from Kristján Valur Jónsson :

It is useful to be able to disable the Nagle algoritm on socket 
connections from the TCPServer.  These are typically used by HTTP servers.

If combined with write buffering (setting RequestHangler.wbufsize = -1) it  
can make sure that http responses are not subject to Nagle/Delayed-ack 
delays.  Disabling Nagle in addition to providing the buffering is 
necessary to make sure that the final wfile.flush() arrives promptly, in 
case a previous flush occurred and the final flush is small.

A patch is provided.

--
files: disable_nagle.patch
keywords: easy, patch, patch
messages: 88878
nosy: krisvale
severity: normal
status: open
title: add disable_nagle_algorithm to SocketServer.TCPServer
type: feature request
versions: Python 2.7
Added file: http://bugs.python.org/file14185/disable_nagle.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Changes by Kristján Valur Jónsson :


--
components: +Library (Lib)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Looks ok to me.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Kristján Valur Jónsson  added the comment:

Committed in revision 73272

--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Antoine Pitrou]

Antoine Pitrou  added the comment:

This patch should be committed to py3k after 3.1 is released.

--
assignee:  -> krisvale
status: closed -> open
versions: +Python 3.2 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Kristján Valur Jónsson  added the comment:

On consideration, it is more appropariate to have the 
disable_nagle_algorithm as part of StreamRequestHandler rather than in the 
TCPSockerServer.  It then sits right next to the rfile and wfile that 
affect it.
The RequestHandlers aren't documented as extensively as the socket 
servers, though, so the documentation will have to go.
Attached is a patch.

--
Added file: http://bugs.python.org/file14306/socketserver2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Kristján Valur Jónsson  added the comment:

Second patch applied in 73546

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Kristján Valur Jónsson  added the comment:

Merged into py3k in revision 73648

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6192] add disable_nagle_algorithm to SocketServer.TCPServer

[Kristján Valur Jónsson]

Changes by Kristján Valur Jónsson :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com