[issue6559] add pass_fds paramter to subprocess.Popen()

[miss-islington]

miss-islington  added the comment:


New changeset 77abf23c67c1a465a8899666c69f6bcd6930e003 by Miss Islington (bot) 
(Orivej Desh) in branch 'master':
bpo-6559: Update _posixsubprocess.fork_exec doc (GH-16283)
https://github.com/python/cpython/commit/77abf23c67c1a465a8899666c69f6bcd6930e003


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Orivej Desh]

Change by Orivej Desh :


--
pull_requests: +15868
pull_request: https://github.com/python/cpython/pull/16283

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

_posixsubprocess.fork_exec docstring was not updated.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Ferringb]

Ferringb ferri...@gmail.com added the comment:

Just noticed this patch... aside from liking the intention, the api for this is 
going to grow tiresome quick since it expects the FDs to already be in place; 
is there any reasons a mapping wasn't used here, specifically of 
(src_fd|src_fileobj) - target_fd ?

If that was fed in, post fork the client can shuffle around the fd's into 
appropriate positions- something the parent may not be able to do (threaded 
environment for example, or async in some respect).

I've had similar functionality in my own process code for a while, and have 
found it to be generally pretty easy to deal with- for subprocess it has the 
added benefit that the existing stdin/stdout/stderr bits could be pretty easily 
folded directly into it.

So... any reason this route wasn't considered, or just wasn't thought about?

--
nosy: +ferringb

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Gregory P. Smith]

Gregory P. Smith g...@krypto.org added the comment:

Wasn't thought about.  I have seen something similar to that done in another 
c++ subprocess implementation since.  If you have suggestions for a more useful 
API, feel free to propose them in a new issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Gregory P. Smith]

Gregory P. Smith g...@krypto.org added the comment:

Bug fix, unittest and documentation added in r87229.  Thanks!

--
resolution:  - accepted
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

It seems there are (intermittent?) test failures:

==
FAIL: test_pass_fds (test.test_subprocess.POSIXProcessTestCase)
--
Traceback (most recent call last):
  File 
/home2/buildbot/slave/3.x.loewis-sun/build/Lib/test/test_subprocess.py, line 
1067, in test_pass_fds
fd to be closed passed)
AssertionError: {5} is not False : fd to be closed passed

==
FAIL: test_pass_fds (test.test_subprocess.ProcessTestCasePOSIXPurePython)
--
Traceback (most recent call last):
  File 
/home2/buildbot/slave/3.x.loewis-sun/build/Lib/test/test_subprocess.py, line 
1067, in test_pass_fds
fd to be closed passed)
AssertionError: {5} is not False : fd to be closed passed

(from 
http://www.python.org/dev/buildbot/all/builders/sparc%20solaris10%20gcc%203.x/builds/2337/steps/test/logs/stdio
 )

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6559] add pass_fds paramter to subprocess.Popen()

[R. David Murray]

Changes by R. David Murray rdmur...@bitdance.com:


--
title: [PATCH]add pass_fds paramter to subprocess.Popen() - add pass_fds 
paramter to subprocess.Popen()
type:  - feature request

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6559
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com