[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Vincent Legoll]

New submission from Vincent Legoll :

The poplib modules use the 'secret' variable during its creation, this
may be a mistake. Perhaps the intention was to use the 'password' instead...

--
components: Library (Lib)
files: py3k-poplib.py-use-wrong-variable.patch
keywords: patch
messages: 91175
nosy: vincele
severity: normal
status: open
title: [RFC] wrong variable used in Lib/poplib.py
versions: Python 3.2
Added file: 
http://bugs.python.org/file14624/py3k-poplib.py-use-wrong-variable.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Mark Dickinson]

Mark Dickinson  added the comment:

Comparing with trunk, I agree that it seems very likely that 'password' is 
intended here.

It's unfortunate that the test-suite doesn't expose this bug;  it would be 
good to come up with a test that covers this.

--
nosy: +marketdickinson
stage:  -> test needed
type:  -> behavior
versions: +Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Vincent Legoll]

Vincent Legoll  added the comment:

Could someone ensure the attached unittest does the job, I blindly
copied from above...

I don't know how to launch an unittest with the svn 'Lib', it takes the
system one and just messing with PYTHONPATH won't work either.

--
Added file: 
http://bugs.python.org/file14649/py3k-poplib.py-use-wrong-variable-unittest.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Mark Dickinson]

Mark Dickinson  added the comment:

> Could someone ensure the attached unittest does the job, I blindly
> copied from above...

Unfortunately it doesn't, because the apop method needs a timestamp in the 
welcome message in order to work.  I've adapted it to make this work---see 
attached patch 'issue6622.patch'.

> I don't know how to launch an unittest with the svn 'Lib', it takes
> the system one and just messing with PYTHONPATH won't work either.

I'm not entirely sure what you're asking here.  On OS X, I usually do 
something like the following at a Terminal prompt:

newton:py3k dickinsm$ ./python.exe Lib/test/test_poplib.py

For better control over output and various other things, use the regrtest 
module:

newton:py3k dickinsm$ ./python.exe Lib/test/regrtest.py -v test_poplib

(execute Lib/test/regrtest.py --help to see a list of options).

--
Added file: http://bugs.python.org/file14669/issue6622.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Mark Dickinson]

Mark Dickinson  added the comment:

Adding Giampaolo Rodola to the nosy list, since he worked on the test code 
recently.  Giampaolo, any comments?

--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

@Mark
I can't test your patch right now as I don't have a Python 3.x installed
here but it looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6622] [RFC] wrong variable used in Lib/poplib.py

[Mark Dickinson]

Mark Dickinson  added the comment:

Patch committed, r74330 (py3k) and r74331 (release31-maint).
Thanks, Giampaolo and Vincent!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com