[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Vidhya]

Vidhya  added the comment:

Thanks Irit for your help.

On Thu., Mar. 3, 2022, 10:17 a.m. Irit Katriel, 
wrote:

>
> Irit Katriel  added the comment:
>
> Thank you @vidhya.
>
> --
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Irit Katriel]

Irit Katriel  added the comment:

Thank you @vidhya.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 09819863a3fb7092ca5cbdfcb722882ebbac806b by Miss Islington (bot) 
in branch '3.9':
bpo-6634: [doc] clarify that sys.exit() does not always exit the interpreter 
(GH-31639) (GH-31661)
https://github.com/python/cpython/commit/09819863a3fb7092ca5cbdfcb722882ebbac806b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[miss-islington]

miss-islington  added the comment:


New changeset 9d9dc59d07d51d73e5af7dd506d0da63aa336995 by Miss Islington (bot) 
in branch '3.10':
bpo-6634: [doc] clarify that sys.exit() does not always exit the interpreter 
(GH-31639)
https://github.com/python/cpython/commit/9d9dc59d07d51d73e5af7dd506d0da63aa336995


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 11.0 -> 12.0
pull_requests: +29778
pull_request: https://github.com/python/cpython/pull/31660

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[miss-islington]

Change by miss-islington :


--
pull_requests: +29779
pull_request: https://github.com/python/cpython/pull/31661

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 10117f1d8cb49ce95493555c06050faf636ccee7 by vidhya in branch 
'main':
bpo-6634: [doc] clarify that sys.exit() does not always exit the interpreter 
(GH-31639)
https://github.com/python/cpython/commit/10117f1d8cb49ce95493555c06050faf636ccee7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Vidhya]

Vidhya  added the comment:

Thanks for your comments :). The PR for the same is:
https://github.com/python/cpython/pull/31639

--
message_count: 21.0 -> 22.0
pull_requests: +29760
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/31639

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Irit Katriel]

Irit Katriel  added the comment:

Vidhya, I think the sentence you are suggesting to add would overlap with one 
which is already there ("Since exit() ultimately “only” raises an exception, it 
will only exit the process when called from the main thread, and the exception 
is not intercepted.")


It seems to me that what could be improved is the first paragraph, which starts 
with: "Exit from Python.".   Maybe instead it could say something like "Raise a 
SystemExit exception, which has the effect of ..." and then say what it is 
(i.e., that it exits python if you are in the main thread, unless the exception 
is caught... ).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Vidhya]

Vidhya  added the comment:

[Entry level contributor seeking guidance]
If this is still open, I can work on this.

I plan to add the following in sys.exit() and add a reference to thread.exit() 
at https://docs.python.org/3/library/sys.html#sys.exit:

When called from a thread other than the main thread, this causes the thread to 
exit silently, and is equivalent to calling :func:`thread.exit`.

Please correct if anything wrong.

--
nosy: +vidhya

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6634] [doc] sys.exit() called from threads other than the main one: undocumented behaviour

[Irit Katriel]

Irit Katriel  added the comment:

Since 3.8 we have threading.excepthook() so the situation is different now: 

https://github.com/python/cpython/pull/13515

I think it still makes sense to change the wording of the doc for sys.exit() a 
bit, and add a reference to the relevant section of the threading doc.

--
keywords: +easy
nosy: +iritkatriel
title: sys.exit() called from threads other than the main one: undocumented 
behaviour -> [doc] sys.exit() called from threads other than the main one: 
undocumented behaviour
type:  -> behavior
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com