[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:

Unlinked bogus revert message.  I checked the file and it has the new function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
Removed message: http://bugs.python.org/msg297751

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[STINNER Victor]

STINNER Victor added the comment:


New changeset 8207c17486baece8ed0ac42d9f8d69ecec4ba7e4 by Victor Stinner in 
branch 'master':
Revert "bpo-30822: Fix testing of datetime module." (#2588)
https://github.com/python/cpython/commit/8207c17486baece8ed0ac42d9f8d69ecec4ba7e4


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:

Test_pyclbr could improve.  There are notes on the PR for a new issue for that. 
 If I find that further change is needed after applying to IDLE's module 
browser, #1612262, that will be another new issue.

--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 246ff3bd00f97658e567a7087645a6b76e056491 by terryjreedy 
(csabella) in branch 'master':
bpo-6691: Pyclbr now reports nested classes and functions. (#2503)
https://github.com/python/cpython/commit/246ff3bd00f97658e567a7087645a6b76e056491


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Cheryl Sabella]

Cheryl Sabella added the comment:

I've created the PR.  I had actually manually looked at classbrowser yesterday. 
 It still works just as it did before this change.  The patch in 1612262 is 
needed for it to loop through the new Object class.

Also, for reference, the test that didn't work initially was the case where 
anything was defined past the second level of nesting of a class, for example 
class -> def -> def or class -> def -> class.  The original patch wasn't adding 
those last items, but now should be.  Ironically, running this over test_pyclbr 
(to parse it, not to run the test), was where I saw that it wasn't showing all 
the nesting.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +2566

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:

PR.  Also manually test classbrowser with the modified pyclbr and report what 
you see on your system.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Cheryl Sabella]

Cheryl Sabella added the comment:

I have the change ready to push.  I didn't change the tests, except to fix what 
was failing earlier, so the tests would need to be reviewed (the test currently 
creates a real temporary file that it opened and read, but a Mock would be 
better?)

Anyway, do you want me to make the PR with what I have or would you rather a 
new diff file?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:

I would like to get this in 3.7.0a1, scheduled for 2017 Sept 9, and 
subsequently in 3.6.3.

Cheryl, this is why I distracted you from the configdialog patch.  As a 
non-idlelib patch, more discussion by more people may be needed before a merge.

If this is not backported to 3.6 Lib/pyclbr, I will backport it to 3.6, maybe 
as Lib/idlelib/_pyclbr, or maybe as a direct addition to browser.py, replacing 
the import statement.

--
assignee:  -> terry.reedy
priority: normal -> high
stage: patch review -> test needed
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Cheryl Sabella]

Cheryl Sabella added the comment:

I'm working on a PR for this.  It passed the existing test cases, but then I 
tried something that didn't pass, so I'm working on fixing that.

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Terry J. Reedy added the comment:

Looking at the code, there are several references to nested classes, implying 
that they should already work.  So I might want to claim this is a behavior 
issue, contrary to my adding 'enhancement' before.  But moot point until patch 
is reviewed and otherwise ready to merge.  And 3.7 would be better than never. 
The patch does have a new test.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
type:  -> enhancement
versions: +Python 3.6 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy:  -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

Too late for version 2. I updated patch for 3.2, and tried to improve the 
documentation a little bit.

--
nosy: +amaury.forgeotdarc
versions:  -Python 2.7, Python 3.1
Added file: http://bugs.python.org/file19100/pyclbr_nested_objects-py3k.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Patch tested ok against 2.7 on windows vista.  Patch seems clean to me, can we 
get this committed please.

--
nosy: +BreamoreBoy
stage:  - patch review
versions: +Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Guilherme Polo]

New submission from Guilherme Polo ggp...@gmail.com:

I have worked on a patch for adding support for nested classes and
nested functions in pyclbr. I believe this might be useful for some
applications, and also for issue1612262.

The patch attached also contains a test and updated documentation.

--
components: Library (Lib)
files: pyclbr_nested_objects.diff
keywords: patch
messages: 91508
nosy: gpolo
severity: normal
status: open
title: Support for nested classes and function for pyclbr
versions: Python 2.7, Python 3.2
Added file: http://bugs.python.org/file14703/pyclbr_nested_objects.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Guilherme Polo]

Changes by Guilherme Polo ggp...@gmail.com:


Removed file: http://bugs.python.org/file14703/pyclbr_nested_objects.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Guilherme Polo]

Changes by Guilherme Polo ggp...@gmail.com:


--
dependencies: +Support for nested classes and function for pyclbr
Added file: http://bugs.python.org/file14704/classbrowser_nesting_support.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Guilherme Polo]

Changes by Guilherme Polo ggp...@gmail.com:


Removed file: http://bugs.python.org/file14704/classbrowser_nesting_support.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6691] Support for nested classes and function for pyclbr

[Guilherme Polo]

Changes by Guilherme Polo ggp...@gmail.com:


--
dependencies:  -Support for nested classes and function for pyclbr
Added file: http://bugs.python.org/file14705/pyclbr_nested_objects.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com