[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Dirkjan Ochtman]

Change by Dirkjan Ochtman :


--
nosy:  -djc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Jean-Paul Calderone]

Changes by Jean-Paul Calderone :


--
nosy:  -Jean-Paul Calderone, exarkun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Jean-Paul Calderone]

Jean-Paul Calderone added the comment:

It's only been six years, no need to rush.

--
nosy: +Jean-Paul Calderone

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Mark Lawrence]

Mark Lawrence added the comment:

I'm assuming that this will not be implemented until 3.6.

--
nosy: +BreamoreBoy
versions: +Python 3.6 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[R. David Murray]

Changes by R. David Murray :


--
type:  -> feature request
versions: +Python 3.3 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Éric Araujo]

Éric Araujo  added the comment:

(Side note: Specifying optional/required extensions from the command line may 
be an interesting new feature in distutils2.)

--
nosy: +eric.araujo
versions:  -Python 2.6, Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Dirkjan Ochtman]

Changes by Dirkjan Ochtman :


--
nosy: +djc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

> `make` will return error:

No it will not. I just tested it: on my Linux system, _bsddb
was not built, yet make reported success even after installing
your patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

> Ok - but your patch does not implement that. If the extension
> fails to compile because the header files are not installed at all,
> even with your patch, there is no error indication.

`make` will return error:

$ cat Makefile
x:
false
all: x
$ make
false
make: *** [x] Error 1
$ 

Also note that my original patch was created before I slightly changed
my suggestion :) .

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

>> Wouldn't be more interesting to add an option where you tell
>> exactly which modules aren't expected to be compiled successfully ?
>> If any modules besides those specified are not built, then setup.py
>> returns 1.
> 
> It's good idea. The option of `configure` could be named
> --enable-extensions=ext1,ext2,...
> 
> --enable-extensions=all could be also supported and it would mean that
> all non-skipped extensions are requested.

I also thought of such a solution, and could accept it.

However, it is really trivial to implement for anybody invoking an
automatic build of Python: after the build completes, do

python -c 'import ext1,ext2,...' 2>/dev/null

and check the return status - and voila, you know whether your required
modules were built successfully.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

> When building of an extension has failed due to external reasons (e.g.
> headers from too old version of a Python dependency), user might prefer
> to be forced to fix these reasons, than to have Python built without an
> extension.

Ok - but your patch does not implement that. If the extension fails to
compile because the header files are not installed at all, even with
your patch, there is no error indication. So according to your
requirements, your patch is incorrect.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

> Wouldn't be more interesting to add an option where you tell
> exactly which modules aren't expected to be compiled successfully ?
> If any modules besides those specified are not built, then setup.py
> returns 1.

It's good idea. The option of `configure` could be named
--enable-extensions=ext1,ext2,...

--enable-extensions=all could be also supported and it would mean that
all non-skipped extensions are requested.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Guilherme Polo]

Guilherme Polo  added the comment:

Wouldn't be more interesting to add an option where you tell exactly
which modules aren't expected to be compiled successfully ? If any
modules besides those specified are not built, then setup.py returns 1.

I, for instance, don't care if the _bsddb extension doesn't get built
but I do care that some others get compiled successfully.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

When building of an extension has failed due to external reasons (e.g.
headers from too old version of a Python dependency), user might prefer
to be forced to fix these reasons, than to have Python built without an
extension. If `make` doesn't fail, user might not notice the problem
during building of Python, but some time later during trying to import
some modules. Such behavior is also especially desired in distributions
(like Gentoo) in which packages are automatically built on users'
systems.

Maybe the option could be named --enable-strict-building-of-extensions?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

>> When they then try to track down the problems, they will
>> (then rightly) complain that the implemented behavior is
>> incorrect.
> 
> setup.py could optionally fail immediately when building of an
> extension has failed.

What about skipped extensions (i.e. those where building them was
not even attempted?)

Why is it interesting to know that building was attempted, but failed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

> When they then try to track down the problems, they will
> (then rightly) complain that the implemented behavior is
> incorrect.

setup.py could optionally fail immediately when building of an
extension has failed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

> If it's not a problem, then the invoker doesn't need to check the exit
> code of setup.py.  Why are you resistant to exposing more information?

Because I believe that the information that is being exposed in this
patch is confusing, and will trick people into believing things that
actually don't happen. When they then try to track down the problems,
they will (then rightly) complain that the implemented behavior is
incorrect.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Guilherme Polo]

Guilherme Polo  added the comment:

> If it's not a problem, then the invoker doesn't need to check the exit
> code of setup.py.

Suppose the _tkinter module failed to compile on a given system, how
would you know if this is a problem or not ? setup.py would return 1
because it couldn't be built, but the rest of Python were compiled
successfully.

--
nosy: +gpolo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Jean-Paul Calderone]

Jean-Paul Calderone  added the comment:

If it's not a problem, then the invoker doesn't need to check the exit
code of setup.py.  Why are you resistant to exposing more information?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

> This makes it more easily possible for automated systems to detect that
> there was a problem with the build.

How do you define "problem" in this context? Why is it a problem if some
extension module did not get built? Perhaps it cannot build correctly
on this system. Is it, or is it not a problem that the module was not
built because header files were lacking that would be available, but
weren't installed on the build machine?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Jean-Paul Calderone]

Jean-Paul Calderone  added the comment:

This makes it more easily possible for automated systems to detect that
there was a problem with the build.

Checking an exit code is easy.  Grabbing and parsing stdout and stderr
is hard and fragile.

--
nosy: +exarkun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Martin v . Löwis]

Martin v. Löwis  added the comment:

Why is it desirable to have such an option?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6731] Add option of non-zero exit status of setup.py when building of extensions has failed

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

An option of `configure` could be added, whose enabling would change
this behavior.

--
title: Non-zero exit status of setup.py when building of extensions has failed 
-> Add option of non-zero exit status of setup.py when building of extensions 
has failed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com