[issue6982] make clean does not remove pickle files
Mark Dickinson dicki...@gmail.com added the comment: I don't think it is safe to remove all *.pickle files in the source directory; even if there aren't any other useful .pickle files right now, there could be in the future (e.g. for pickle testing). I'd prefer something more targeted. Are these .pickle files generated during the build process, or just during testing? Maybe it should be the responsibility of the 2to3 tests to clean up after themselves? -- nosy: +mark.dickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
egreen egr...@operamail.com added the comment: These .pickle files aren't created by the tests themselves, but they do show up after running 'make test', or more specifically after running './python Lib/test/regrtest.py -v test_lib2to3'. This is because a grammar generated from a .txt grammar file is cached as a pickle for faster access by load_grammar in Lib/lib2to3/pgen2/driver.py. A pickle file then ends up in the same directory as the .txt file. IMHO, though it may be preferable to remove just the pickle files in Lib/lib2to3, it should never be required for tests to have pickle files already available in the source tree. Instead, the test should create a temporary pickle file, e.g. from a bytes object. Furthermore, binary files shouldn't be versioned without good reason. Thus, removing all pickle files should be safe for the future. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
Mark Dickinson dicki...@gmail.com added the comment: IMHO, though it may be preferable to remove just the pickle files in Lib/lib2to3, Sounds reasonable. it should never be required for tests to have pickle files already available in the source tree. Well, I don't know about 'should', but the current tests already do make use of pickle files in the source tree: see Lib/test/*.pck. So there are already versioned pickle files (but not .pickle files :-). -- versions: +Python 2.6, Python 2.7 -Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
egreen egr...@operamail.com added the comment: You are right. Guess I was being a little too dogmatic. :-) I hadn't found those .pck files, because I was only looking for binary files. Here's a new patch proposal. -- Added file: http://bugs.python.org/file14962/clean-grammar-pickles.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
Mark Dickinson dicki...@gmail.com added the comment: Thanks! I'll apply this later today, unless Benjamin gets there first. :) -- resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
Mark Dickinson dicki...@gmail.com added the comment: Committed in r75047 (trunk). Merged in r75048 (release26-maint), r75049 (py3k) and r75050 (release31-maint). -- assignee: - mark.dickinson stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
New submission from egreen egr...@operamail.com: make clean and make distclean don't remove the grammar pickles generated by load_grammar in Lib/lib2to3/pgen2/driver.py (Lib/lib2to3/Grammar3.2.0.alpha.0.pickle, Lib/lib2to3/PatternGrammar3.2.0.alpha.0.pickle). Proposed patch attached. It removes all *.pickle files, which I assume is safe. (Patch also corrects a comment.) -- components: 2to3 (2.x to 3.0 conversion tool), Build files: clean-pickles.patch keywords: patch messages: 93049 nosy: egreen severity: normal status: open title: make clean does not remove pickle files versions: Python 3.0, Python 3.1, Python 3.2 Added file: http://bugs.python.org/file14960/clean-pickles.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6982] make clean does not remove pickle files
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +benjamin.peterson priority: - low stage: - patch review type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6982 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
