[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Boštjan Mejak bostjan.me...@gmail.com added the comment: I'm reopening this and I am making it a feature request for Python 3.2 -- components: +Interpreter Core -Documentation resolution: wont fix - status: closed - open type: - feature request versions: -Python 2.6, Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Changes by Georg Brandl ge...@python.org: -- assignee: georg.brandl - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Changes by Georg Brandl ge...@python.org: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Changes by Éric Araujo mer...@netwok.org: -- resolution: fixed - wont fix stage: - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Éric Araujo mer...@netwok.org added the comment: Your patch need to include an alias (BadZipfile = BadZipFile) to preserve compatibility with old pickles, as explains msg95477. Cheers -- nosy: +Merwok ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Antoine Pitrou pit...@free.fr added the comment: While the mismatched casing is unfortunate, I don't think changing it for the sake of aesthetics is a good deal given that many existing programs will have to be converted to the new spelling. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Retro vinet...@gmail.com added the comment: I suggest renaming the class from BadZipfile to BadZipFile. We have a class named LargeZipFile. It would make sence to have the previously mentioned class named as BadZipFile then. What is your verdict on that? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Ezio Melotti ezio.melo...@gmail.com added the comment: The old name could be deprecated and replaced by the right one, but as Eric Smith mentioned on #python-dev, the class with the old name can't be removed because - even if unlikely - the object might exist in a pickle. So we can either live with the wrong name or deprecate it, fix the places where it's used and live with a deprecated version that can't be removed. -- nosy: +ezio.melotti priority: - low ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Retro vinet...@gmail.com added the comment: I am merely speaking of renaming the class name from BadZipfile to BadZipFile. class BadZipFile(exceptions.Exception): # etc. Only the name is fixed at class definition. I am aiming for that in this bug report. And then every other BadZipfile should be fixed to BadZipFile. Is that doable? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Ezio Melotti ezio.melo...@gmail.com added the comment: It might be doable for Python and its stdlib, but all the programs and modules that are using the old name will start raising errors if they don't find the old name anymore. If the old name is deprecated for at least one Python version (e.g. 2.7/3.2), these programs can fix it and then, after a few versions (e.g. 3.3), the old name can finally be removed. There is still the pickle issue, even if IMHO it's so unlikely that it shouldn't be relevant. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Retro vinet...@gmail.com added the comment: I made a patch which fixes the BadZipfile issue. Please take a look and decide whether you'll toss it or use it. Maybe it'll come handy some other time in the future. -- keywords: +patch Added file: http://bugs.python.org/file15365/zipfile-patch.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
New submission from Retro vinet...@gmail.com: There are some minor typos in the docs. The section zipfile has twp typos: exception zipfile.BadZipfile The error raised for bad ZIP files (old name: zipfile.error). this should be exception zipfile.BadZipFile The error raised for bad ZIP files (old name: zipfile.error). Note: There needs to be a capital F in the exception class name BadZipFile. There's also a typo in the sentence Decryption is extremely slow as it is implemented in native python rather than C. which should be Decryption is extremely slow as it is implemented in native Python rather than C. This sentence is found just above the previous BadZipfile typo. Note: The word 'python' is needed to be capitalized. These typos exist since the creation of the zipfile docs. Please correct the docs for the selected versions. Thank you. -- assignee: georg.brandl components: Documentation messages: 95442 nosy: Retro, georg.brandl severity: normal status: open title: Documentation typos found in zipfile — Work with ZIP archives versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Georg Brandl ge...@python.org added the comment: BadZipfile is actually the correct name of the exception. Fixed the other nit in r76376. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7351] Documentation typos found in zipfile — Work with ZIP archives
Retro vinet...@gmail.com added the comment: Thanks for upcassing 'Python'. I have to ask you why are all other classes named in the form of ...ZipFile, like - exception: LargeZipFile - class: ZipFile - class: PyZipFile Please at least consider of making the class BadZipfile consistent to other classes and let it be renamed to BadZipFile. Thank you again. -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7351 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
