[issue766910] fix one or two bugs in trace.py

[Daniel Diniz]

Change by Daniel Diniz :


--
nosy: +ajaksu2
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
assignee: belopolsky -> 
versions: +Python 3.7 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy:  -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Eli Bendersky]

Eli Bendersky added the comment:

Ah, no time, no time... :-/

I may get back to this in the future. Bumping to more relevant versions for now.

--
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Mark Lawrence]

Mark Lawrence added the comment:

Just a gentle bump.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

On Sat, Dec 4, 2010 at 3:34 AM, Eli Bendersky rep...@bugs.python.org wrote:
..
 However, while experimenting, I think I ran into much larger problems. Either 
 that or I've forgotten
 how to use the module :-)

I am afraid it is the latter. :-)  The file specified in --file option
should be a pickle, not a coverage file from the previous run.

$ ./python.exe -m trace -s -f counts.pickle -c trace_target.py
K is 380
Skipping counts file 'counts.pickle': [Errno 2] No such file or
directory: 'counts.pickle'
lines   cov%   module   (path)
1   100%   trace   (/Users/sasha/Work/python-svn/py3k-commit/Lib/trace.py)
9   100%   trace_target   (trace_target.py)
6   100%   traced_module   (traced_module.py)

$ ./python.exe -m pickletools counts.pickle
0: (MARK
1: }EMPTY_DICT
2: qBINPUT 0
4: (MARK
5: (MARK
6: XBINUNICODE 'trace_target.py'
...

However, there is a problem here, I think:

$ ./python.exe -m trace -s -f counts.pickle -c trace_target.py
K is 380
lines   cov%   module   (path)
1   100%   trace   (/Users/sasha/Work/python-svn/py3k-commit/Lib/trace.py)
9   100%   trace_target   (trace_target.py)
6   100%   traced_module   (traced_module.py)
$ ./python.exe -m trace -s -f counts.pickle -c trace_target.py
K is 380
lines   cov%   module   (path)
1   100%   trace   (/Users/sasha/Work/python-svn/py3k-commit/Lib/trace.py)
9   100%   trace_target   (trace_target.py)
6   100%   traced_module   (traced_module.py)

The counts should grow in repeated runs.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

On Wed, Jan 12, 2011 at 12:17 PM, Alexander Belopolsky
rep...@bugs.python.org wrote:
..
 The counts should grow in repeated runs.

I did not pay attention: the numbers in summary are numbers of lines,
not execution counts.  The execution counts in .cover file grow as
expected.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

On Sat, Dec 4, 2010 at 3:34 AM, Eli Bendersky rep...@bugs.python.org wrote:
..
 I reviewed the patch and ported the changes to the newest sources

Eli,

I don't think you ever posted an updated patch.  Do you still have it?

This may be a good starting issue for you as a committer.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Eli Bendersky]

Eli Bendersky eli...@gmail.com added the comment:

Alexander, 

I reviewed the patch and ported the changes to the newest sources (since the 
fix to issue 9299, os.makedirs can be naturally used with its new flag to fix 
the bug Zooko refers to).

However, while experimenting, I think I ran into much larger problems. Either 
that or I've forgotten how to use the module :-) Attaching two files (one 
imports the other) on which I try to run the following:

python -m trace -c trace_target.py

 OK: I get trace_target.cover  traced_module.cover created

However, now running:

python -m trace -r --file=trace_target.cover

 ...
pickle.load(open(self.infile, 'rb'))
_pickle.UnpicklingError: invalid load key, ' '.

Also, trying to provide --file to -c:

python -m trace -c trace_target.py --file=xyz.cover

 xyz.cover is ignored and the same two .cover files are created.

Can you take a look at this?

--
Added file: http://bugs.python.org/file19933/trace_target.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Eli Bendersky]

Changes by Eli Bendersky eli...@gmail.com:


Added file: http://bugs.python.org/file19934/traced_module.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


Removed file: http://bugs.python.org/file18959/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


Removed file: http://bugs.python.org/file18960/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Alexander Belopolsky belopol...@users.sourceforge.net added the comment:

Eli,

Would you like to review this patch?

--
nosy: +eli.bendersky -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Guido van Rossum]

Changes by Guido van Rossum gu...@python.org:


--
Removed message: http://bugs.python.org/msg117114

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Guido van Rossum]

Changes by Guido van Rossum gu...@python.org:


--
Removed message: http://bugs.python.org/msg117113

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


Removed file: http://bugs.python.org/file8481/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Alexander Belopolsky]

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


--
assignee:  - belopolsky
nosy: +belopolsky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Please ensure tha I'm taken off of the email list as I've been banned from 
contributing to Python by Raymond Hettinger


From: Alexander Belopolsky rep...@bugs.python.org
To: breamore...@yahoo.co.uk
Sent: Tue, 21 September, 2010 19:30:44
Subject: [issue766910] fix one or two bugs in trace.py

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:

Removed file: http://bugs.python.org/file8481/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___

--
Added file: http://bugs.python.org/file18959/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___htmlheadstyle type=text/css!-- DIV {margin:0px;} 
--/style/headbodydiv style=font-family:times new roman,new 
york,times,serif;font-size:12ptdivPlease ensure tha I'm taken off of the 
email list as I've been banned from contributing to Python by Raymond 
Hettingerbr/divdiv style=font-family: times new roman,new 
york,times,serif; font-size: 12pt;brdiv style=font-family: 
arial,helvetica,sans-serif; font-size: 13px;font face=Tahoma size=2hr 
size=1bspan style=font-weight: bold;From:/span/b Alexander 
Belopolsky lt;rep...@bugs.python.orggt;brbspan style=font-weight: 
bold;To:/span/b breamore...@yahoo.co.ukbrbspan style=font-weight: 
bold;Sent:/span/b Tue, 21 September, 2010 19:30:44brbspan 
style=font-weight: bold;Subject:/span/b [issue766910] fix one or two 
bugs in trace.pybr/fontbrbrChanges by Alexander Belopolsky lt;a
 ymailto=mailto:belopol...@users.sourceforge.net; 
href=mailto:belopol...@users.sourceforge.net;belopol...@users.sourceforge.net/agt;:brbrbrRemoved
 file: a href=http://bugs.python.org/file8481/unnamed; 
target=_blankhttp://bugs.python.org/file8481/unnamed/abrbr___brPython
 tracker lt;a ymailto=mailto:rep...@bugs.python.org; 
href=mailto:rep...@bugs.python.org;rep...@bugs.python.org/agt;brlt;a 
href=http://bugs.python.org/issue766910; 
target=_blankhttp://bugs.python.org/issue766910/agt;br___br/div/div
/divbr



  /body/html___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Please ensure tha I'm taken off of the email list as I've been banned from 
contributing to Python by Raymond Hettinger


From: Alexander Belopolsky rep...@bugs.python.org
To: breamore...@yahoo.co.uk
Sent: Tue, 21 September, 2010 19:35:10
Subject: [issue766910] fix one or two bugs in trace.py

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:

--
assignee:  - belopolsky
nosy: +belopolsky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___

--
Added file: http://bugs.python.org/file18960/unnamed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___htmlheadstyle type=text/css!-- DIV {margin:0px;} 
--/style/headbodydiv style=font-family:times new roman,new 
york,times,serif;font-size:12ptdivPlease ensure tha I'm taken off of the 
email list as I've been banned from contributing to Python by Raymond 
Hettingerbr/divdiv style=font-family: times new roman,new 
york,times,serif; font-size: 12pt;brdiv style=font-family: 
arial,helvetica,sans-serif; font-size: 13px;font face=Tahoma size=2hr 
size=1bspan style=font-weight: bold;From:/span/b Alexander 
Belopolsky lt;rep...@bugs.python.orggt;brbspan style=font-weight: 
bold;To:/span/b breamore...@yahoo.co.ukbrbspan style=font-weight: 
bold;Sent:/span/b Tue, 21 September, 2010 19:35:10brbspan 
style=font-weight: bold;Subject:/span/b [issue766910] fix one or two 
bugs in trace.pybr/fontbrbrChanges by Alexander Belopolsky lt;a
 ymailto=mailto:belopol...@users.sourceforge.net; 
href=mailto:belopol...@users.sourceforge.net;belopol...@users.sourceforge.net/agt;:brbrbr--brassignee:nbsp;
 -gt; belopolskybrnosy: 
+belopolskybrbr___brPython tracker 
lt;a ymailto=mailto:rep...@bugs.python.org; 
href=mailto:rep...@bugs.python.org;rep...@bugs.python.org/agt;brlt;a 
href=http://bugs.python.org/issue766910; 
target=_blankhttp://bugs.python.org/issue766910/agt;br___br/div/div
/divbr



  /body/html___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Is there any interest in this issue?

--
nosy: +BreamoreBoy
type:  - behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Skip Montanaro]

Changes by Skip Montanaro s...@pobox.com:


--
nosy:  -skip.montanaro

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue766910
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Skip Montanaro]

Skip Montanaro [EMAIL PROTECTED] added the comment:

unassigning

--
assignee: skip.montanaro - 


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue766910

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Isaac Morland]

Isaac Morland added the comment:

I would suggest that the need to create directories that may already
exist (really ensure existence of directories) is not exclusive to
trace.py.  I am suggesting this be added as an option to os.mkdir and
os.makedirs.  See Issue 1675.

--
nosy: +ijmorlan


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue766910

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Zooko O'Whielacronx]

Zooko O'Whielacronx added the comment:

Hi!  Sorry it took me so long to look at this.  I just checked the  
source in current trunk, and the relevant code is the same so this  
patch is still useful.  (See the initial post for details.)

Here is an updated version of the patch which simply removes some  
dead code and updates a URL:

regards,

Zooko

diff -rN -u old-up/setuptools-0.6c7/ez_setup.py new-up/ 
setuptools-0.6c7/ez_setup.py
--- old-up/setuptools-0.6c7/ez_setup.py 2007-09-28 16:41:24.0  
-0600
+++ new-up/setuptools-0.6c7/ez_setup.py 2007-09-28 16:41:25.0  
-0600
@@ -1,4 +1,4 @@
-#!python
+#!/usr/bin/env python
Bootstrap setuptools installation
If you want to use setuptools in your package's setup.py, just  
include this
@@ -13,7 +13,7 @@
This file can also be run as a script to install or upgrade setuptools.

-import sys
+import os, re, subprocess, sys
DEFAULT_VERSION = 0.6c7
DEFAULT_URL = http://pypi.python.org/packages/%s/s/setuptools/;  
% sys.version[:3]
@@ -44,8 +44,6 @@
  'setuptools-0.6c6-py2.5.egg': 'b2f8a7520709a5b34f80946de5f02f53',
}
-import sys, os
-
def _validate_md5(egg_name, data):
  if egg_name in md5_data:
  from md5 import md5
@@ -58,6 +56,42 @@
  sys.exit(2)
  return data
+# The following code to parse versions is copied from  
pkg_resources.py so that
+# we can parse versions without importing that module.
+component_re = re.compile(r'(\d+ | [a-z]+ | \.| -)', re.VERBOSE)
+replace = {'pre':'c',  
'preview':'c','-':'final-','rc':'c','dev':'@'}.get
+
+def _parse_version_parts(s):
+for part in component_re.split(s):
+part = replace(part,part)
+if not part or part=='.':
+continue
+if part[:1] in '0123456789':
+yield part.zfill(8)# pad for numeric comparison
+else:
+yield '*'+part
+
+yield '*final'  # ensure that alpha/beta/candidate are before final
+
+def parse_version(s):
+parts = []
+for part in _parse_version_parts(s.lower()):
+if part.startswith('*'):
+if part'*final':   # remove '-' before a prerelease tag
+while parts and parts[-1]=='*final-': parts.pop()
+# remove trailing zeros from each series of numeric parts
+while parts and parts[-1]=='':
+parts.pop()
+parts.append(part)
+return tuple(parts)
+
+def setuptools_is_new_enough(required_version):
+Return True if setuptools is already installed and has a version
+number = required_version.
+sub = subprocess.Popen([sys.executable, -c, import  
setuptools;print setuptools.__version__], stdout=subprocess.PIPE)
+verstr = sub.stdout.read().strip()
+ver = parse_version(verstr)
+return ver and ver = parse_version(required_version)
def use_setuptools(
  version=DEFAULT_VERSION, download_base=DEFAULT_URL,  
to_dir=os.curdir,
@@ -74,32 +108,11 @@
  this routine will print a message to ``sys.stderr`` and raise  
SystemExit in
  an attempt to abort the calling script.
  
-try:
-import setuptools
-if setuptools.__version__ == '0.0.1':
-print sys.stderr, (
-You have an obsolete version of setuptools installed.   
Please\n
-remove it from your system entirely before rerunning  
this script.
-)
-sys.exit(2)
-except ImportError:
+if not setuptools_is_new_enough(version):
  egg = download_setuptools(version, download_base, to_dir,  
download_delay)
  sys.path.insert(0, egg)
  import setuptools; setuptools.bootstrap_install_from = egg
-import pkg_resources
-try:
-pkg_resources.require(setuptools=+version)
-
-except pkg_resources.VersionConflict, e:
-# XXX could we install in a subprocess here?
-print sys.stderr, (
-The required version of setuptools (=%s) is not  
available, and\n
-can't be installed while this script is running. Please  
install\n
- a more recent version first.\n\n(Currently using %r)
-) % (version, e.args[0])
-sys.exit(2)
-
def download_setuptools(
  version=DEFAULT_VERSION, download_base=DEFAULT_URL,  
to_dir=os.curdir,
  delay = 15
@@ -150,9 +163,14 @@
def main(argv, version=DEFAULT_VERSION):
  Install or upgrade setuptools and EasyInstall
-try:
-import setuptools
-except ImportError:
+if setuptools_is_new_enough(version):
+if argv:
+from setuptools.command.easy_install import main
+main(argv)
+else:
+print Setuptools version,version,or greater has been  
installed.
+print '(Run ez_setup.py -U setuptools to reinstall or  
upgrade.)'
+else:
  egg = None
  try:
  egg = download_setuptools(version, delay=0)
@@ -162,31 +180,6 @@
  finally:
  if egg and os.path.exists(egg):
  os.unlink(egg)
-

[issue766910] fix one or two bugs in trace.py

[Zooko O'Whielacronx]

Zooko O'Whielacronx added the comment:

 Here is an updated version of the patch which simply removes some  
 dead code and updates a URL:

 regards,

 Zooko

 diff -rN -u old-up/setuptools-0.6c7/ez_setup.py new-up/ 
 setuptools-0.6c7/ez_setup.py
 --- old-up/setuptools-0.6c7/ez_setup.py   2007-09-28  
 16:41:24.0 -0600
 +++ new-up/setuptools-0.6c7/ez_setup.py   2007-09-28  
 16:41:25.0 -0600

Oops, the in-lined patch contents were a different patch entirely,  
but the attached patch file was correct.

Just for completeness, here is the correct in-lined patch contents:

Index: Lib/trace.py
===
--- Lib/trace.py(revision 58282)
+++ Lib/trace.py(working copy)
@@ -85,7 +85,12 @@
-r, --report  Generate a report from a counts file; do not  
execute
any code.  `--file' must specify the results  
file to
read, which must have been created in a  
previous run
-  with `--count --file=FILE'.
+  with `--count --file=FILE'.  If --coverdir is not
+  specified, the .cover files will be written  
into the
+  directory that the modules were in when the  
report was
+  generated.  Whether or not --coverdir is  
specified,
+  --report will always create the cover file  
directory if
+  necessary.
Modifiers:
-f, --file=file File to accumulate counts over several runs.
@@ -197,6 +202,33 @@
  filename, ext = os.path.splitext(base)
  return filename
+# The following function is copied from the fileutil module from the  
pyutil
+# project:
+# http://pypi.python.org/pypi/pyutil
+# We use this function instead of os.makedirs() so that we don't get a
+# spurious exception when someone else creates the directory at the  
same
+# moment we do.  (For example, another thread or process that is  
also running
+# trace.)
+def make_dirs(dirname, mode=0777):
+
+A threadsafe and idempotent version of os.makedirs().  If the  
dir already
+exists, do nothing and return without raising an exception.  If  
this call
+creates the dir, return without raising an exception.  If there  
is an
+error that prevents creation or if the directory gets deleted after
+make_dirs() creates it and before make_dirs() checks that it  
exists, raise
+an exception.
+
+tx = None
+try:
+os.makedirs(dirname, mode)
+except OSError, x:
+tx = x
+
+if not os.path.isdir(dirname):
+if tx:
+raise tx
+raise exceptions.IOError, unknown error prevented creation  
of directory, or deleted the directory immediately after creation: % 
s % dirname # careful not to construct an IOError with a 2-tuple, as  
that has a special meaning...
+
class CoverageResults:
  def __init__(self, counts=None, calledfuncs=None, infile=None,
   callers=None, outfile=None):
@@ -290,15 +322,15 @@
  if filename.endswith((.pyc, .pyo)):
  filename = filename[:-1]
-if coverdir is None:
+if coverdir is not None:
+dir = coverdir
+modulename = fullmodname(filename)
+else:
  dir = os.path.dirname(os.path.abspath(filename))
  modulename = modname(filename)
-else:
-dir = coverdir
-if not os.path.exists(dir):
-os.makedirs(dir)
-modulename = fullmodname(filename)
+make_dirs(dir)
+
  # If desired, get a list of the line numbers which  
represent
  # executable content (returned as a dict for better  
lookup speed)
  if show_missing:


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue766910

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue766910] fix one or two bugs in trace.py

[Skip Montanaro]

Skip Montanaro added the comment:

Zooko, is this patch still necessary?

--
assignee:  - skip.montanaro
nosy: +skip.montanaro


Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue766910

___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com