[issue7719] distutils: ignore .nfsXXXX files
Roundup Robot added the comment: New changeset d978828bfd0e by Éric Araujo in branch '3.2': Ignore .nfs* files in distutils (#7719). http://hg.python.org/cpython/rev/d978828bfd0e New changeset 10ab746f55fb by Éric Araujo in branch '3.3': Merge fixes for #13614, #13512 and #7719 from 3.2 http://hg.python.org/cpython/rev/10ab746f55fb New changeset b10c1c6f869f by Éric Araujo in branch 'default': Merge fixes for #13614, #13512 and #7719 from 3.3 http://hg.python.org/cpython/rev/b10c1c6f869f -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo added the comment: Thanks all! -- resolution: - fixed stage: commit review - committed/rejected status: open - closed versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo mer...@netwok.org added the comment: SilentGhost, could you submit a contributor agreement to the PSF for your patches? See http://www.python.org/psf/contrib/ . Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset a56cebff113a by Éric Araujo in branch '2.7': Ignore .nfs* files in distutils (#7719). http://hg.python.org/cpython/rev/a56cebff113a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Changes by Hynek Schlawack h...@ox.cx: -- nosy: -hynek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Jeff Ramnani j...@jefframnani.com added the comment: Hynek, I would indeed like to update this patch. I will make the updates you have suggested. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Jeff Ramnani j...@jefframnani.com added the comment: Attached the updated patch. I have added a .nfs file to test_prune_file_list in test_sdist. I've also cleaned up the documentation to read a little better (IMO). -- Added file: http://bugs.python.org/file25668/issue7719-nfs_silly_rename.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo mer...@netwok.org added the comment: Thanks, will apply. -- stage: test needed - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Hynek Schlawack h...@ox.cx added the comment: Jeff, are you still interested in updating your patch or would you prefer if someone else tackled it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Charles-François Natali neolo...@free.fr added the comment: Wouldn't it be better to add an 'ignore' option to the copy_tree() method with an optional list of patterns to ignore instead of hardcoding '.nsfXXX' files? This would make it possible to also skip '.hg', 'CVS' artifacts. -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo mer...@netwok.org added the comment: No improvements are done in distutils, only the smallest possible changes to fix bugs. In distutils2 we use shutil.copytree. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Hynek Schlawack h...@ox.cx added the comment: Jeff, the patch LGTM but Eric indicated he'd like to have a higher level test inside Lib/distutils/tests/test_sdist.py. Possibly as part of a bigger test like test_prune_file_list or test_add_defaults; no need to remove the old test though I guess. P.S. There's an extra empty line inside of apiref.rst. You may want to strip it from your next patch. -- nosy: +hynek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Jeff Ramnani j...@jefframnani.com added the comment: I've updated SilentGhost's patch to include a test and documentation. -- nosy: +jramnani Added file: http://bugs.python.org/file24828/issue7719-nfs_silly_rename.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo mer...@netwok.org added the comment: Thanks to Sandro’s explanation and a passage in the Unix Haters Handbook, I now think that ignoring .nfs* files is a safe change. If should not be hard to add a test for this in test_sdist. -- assignee: tarek - eric.araujo keywords: +easy versions: +3rd party ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Zbyszek Szmek zbys...@in.waw.pl added the comment:
Review of both patches (python-2.5.1-distutils-aixnfs.patch and
dir_util.py.diff) as they are essentially the same:
I think that the test is in wrong place: we would want to ignore those .nfs*
files always, not just when checking for symlinks. A separate test
at the top of the loop would be better:
for n in names:
+ if n.startswith('.nfs'):
+ continue
src_name = os.path.join(src, n)
dst_name = os.path.join(dst, n)
if preserve_symlinks and os.path.islink(src_name):
BTW: under linux 2.6.20 I see files like: .nfs059241390036, always
of this length, with hexadecimal digits after .nfs).
--
nosy: +zbysz
versions: +Python 3.3 -3rd party, Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7719
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Éric Araujo mer...@netwok.org added the comment: Thanks for the report and patch (I think SilentGhost’s version is better). Do you have any pointer about those .nfs* files? Are there other (build) tools that ignore them? Is it always safe to skip .nfs* files, or only .nfs? (i.e. six characters)? Aside from those questions, a patch requires a test and doc update. See guidelines at http://wiki.python.org/moin/Distutils/FixingBugs -- components: +Distutils2 nosy: +eric.araujo versions: +3rd party ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Sandro Tosi sandro.t...@gmail.com added the comment: On Tue, Feb 8, 2011 at 23:40, Éric Araujo rep...@bugs.python.org wrote: Éric Araujo mer...@netwok.org added the comment: Do you have any pointer about those .nfs* files? Are there other (build) tools that ignore them? Is it always safe to skip .nfs* files, or only .nfs? (i.e. six characters)? Just replying for this part: .nfs* files are created by the nfs server when on of its client removes a file while another client has the very same file opened. the nfs server keeps the .nfs* file around until the last client closes the file, after that it removes the .nfs* file. About the number of digits after '.nfs' I'm not sure there's a standard for it, but I saw files with more that 6 chars after that. Regards, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- nosy: +sandro.tosi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Changes by Michael Haubenwallner michael.haubenwall...@salomon.at: -- nosy: +haubi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
SilentGhost ghost@gmail.com added the comment: Here is the applicable patch against py3k branch. -- nosy: +SilentGhost Added file: http://bugs.python.org/file20710/dir_util.py.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- versions: +Python 3.1, Python 3.2 -Python 2.5, Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
New submission from Fabian Groffen grob...@gentoo.org: NFS on certain platforms (most notably AIX, Solaris) use .nfsX files that appear and disappear automagically. distutils can get confused by that once a .nfsX file was earlier seen with listdir and then removed by the OS before its copied. Simply ignore .nfsX files as workaround. -- assignee: tarek components: Distutils files: python-2.5.1-distutils-aixnfs.patch keywords: patch messages: 97898 nosy: grobian, tarek severity: normal status: open title: distutils: ignore .nfs files type: behavior versions: Python 2.5, Python 2.6, Python 2.7 Added file: http://bugs.python.org/file15918/python-2.5.1-distutils-aixnfs.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7719] distutils: ignore .nfsXXXX files
Changes by Brian Curtin cur...@acm.org: -- keywords: +needs review priority: - normal stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7719 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
