[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-18 Thread Alexander Belopolsky

Changes by Alexander Belopolsky belopol...@users.sourceforge.net:


--
keywords:  -needs review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-04 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-04 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

I believe Brett meant to leave this open until he finished it by backporting to 
2.7 (which is now reopened for patches). Otherwise, it might get forgotten.

Sidenote: this is the issue I referred to in #9132 re the 'patch' keyword.

--
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-04 Thread Brett Cannon

Brett Cannon br...@python.org added the comment:

On Sun, Jul 4, 2010 at 17:01, Terry J. Reedy rep...@bugs.python.org wrote:

 I believe Brett meant to leave this open until he finished it by backporting 
 to 2.7 (which is now reopened for patches). Otherwise, it might get forgotten.

Exactly right, Terry.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-02 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

Brett, should this be reassigned to d...@python? I gave a suggested text change 
months ago. The need for a change like this was mentioned again today on pydev 
in the thread Can Python implementations reject semantically invalid 
expressions?. Since the current deficiency has been noted repeatedly, I think 
the priority should be at least normal.

Unless someone suggests something even better, I think my proposed replacememt 
should be accepted, formatted, and applied. I think it is definitely better 
than the current text.

--
priority: low - normal

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-02 Thread Brett Cannon

Brett Cannon br...@python.org added the comment:

Sorry, Terry, I didn't even notice the corrections in the issue since they were 
inlined in a comment instead of as an attached file. I will have a look right 
now.

--
keywords: +needs review
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-07-02 Thread Brett Cannon

Brett Cannon br...@python.org added the comment:

Fixed in r82456. I decided to make a warning directive so that it's really 
obvious that people should not consider the dis module and bytecode as stable.

Once Python 2.7.0final is out the door I will backport the patch.

--
resolution:  - fixed
stage: patch review - committed/rejected
versions: +Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-02-06 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +Merwok

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-02-05 Thread Terry J. Reedy

Terry J. Reedy tjre...@udel.edu added the comment:

The doc begins
30.12. dis — Disassembler for Python bytecode
The dis module supports the analysis of Python bytecode by disassembling it. 
Since there is no Python assembler, this module defines the Python assembly 
language. The Python bytecode which this module takes as an input is defined in 
the file Include/opcode.h and used by the compiler and the interpreter.

This goes back to when python.exe (CPython) was the only implementation. 
Python bytecode is no longer appropriate. It should be changed to CPython 
bytecode. My suggestion for a possible update:

30.12. dis — Disassembler for CPython bytecode
CPython currently compiles Python source code to a custom bytecode that is 
defined by the CPytyon source file Include/opcode.h and explained below. While 
such implementation details are subject to change in any CPython x.y version, 
the dis module supports the analysis of current bytecode by disassembling it to 
a format similar to assembly language.

Calling it an actual assembly language, as the current doc does, implies to me 
that there is/should be an assembler (which Guido has said there should not be).

30.12.1. Python Bytecode Instructions
The Python compiler ...

Python - CPython

In the glossary:
bytecode 
Python source code is compiled into bytecode, the internal representation of a 
Python program in the interpret
= something like
bytecode
CPython currently compiles Python source code to an internal bytecode 
representation that it uses to execute the program. Some other implementations 
do something similar.

These suggestions touch on the larger issue of differentiating and 
disentangling language doc from CPython implementation doc. I support this even 
though I have never used any of the other implementations.

--
nosy: +tjreedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-02-03 Thread Brett Cannon

Changes by Brett Cannon br...@python.org:


--
priority:  - low
stage:  - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-02-01 Thread Jean-Paul Calderone

New submission from Jean-Paul Calderone exar...@divmod.com:

From python-dev:

On Fri, Jan 29, 2010 at 15:04,  exar...@twistedmatrix.com wrote:
 On 10:47 pm, tjre...@udel.edu wrote:

 On 1/29/2010 4:19 PM, Collin Winter wrote:

 On Fri, Jan 29, 2010 at 7:22 AM, Nick Coghlanncogh...@gmail.com wrote:

 Agreed. We originally switched Unladen Swallow to wordcode in our
 2009Q1 release, and saw a performance improvement from this across the
 board. We switched back to bytecode for the JIT compiler to make
 upstream merger easier. The Unladen Swallow benchmark suite should
 provided a thorough assessment of the impact of the wordcode -
 bytecode switch. This would be complementary to a JIT compiler, rather
 than a replacement for it.

 I would note that the switch will introduce incompatibilities with
 libraries like Twisted. IIRC, Twisted has a traceback prettifier that
 removes its trampoline functions from the traceback, parsing CPython's
 bytecode in the process. If running under CPython, it assumes that the
 bytecode is as it expects. We broke this in Unladen's wordcode switch.
 I think parsing bytecode is a bad idea, but any switch to wordcode
 should be advertised widely.

 Several years, there was serious consideration of switching to a
 registerbased vm, which would have been even more of a change. Since I
 learned 1.4, Guido has consistently insisted that the CPython vm is not part
 of the language definition and, as far as I know, he has rejected any byte-
 code hackery in the stdlib. While he is not one to, say, randomly permute
 the codes just to frustrate such hacks, I believe he has always considered
 vm details private and subject to change and any usage thereof 'at one's own
 risk'.

 Language to such effect might be a useful addition to this page (amongst
 others, perhaps):

  http://docs.python.org/library/dis.html

 which very clearly and helpfully lays out quite a number of APIs which can
 be used to get pretty deep into the bytecode.  If all of this is subject to
 be discarded at the first sign that doing so might be beneficial for some
 reason, don't keep it a secret that people need to join python-dev to learn.


Can you file a bug and assign it to me?

-Brett

--
assignee: georg.brandl
components: Documentation
messages: 98661
nosy: exarkun, georg.brandl
severity: normal
status: open
title: dis module documentation gives no indication of the dangers of bytecode 
inspection

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7829] dis module documentation gives no indication of the dangers of bytecode inspection

2010-02-01 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
assignee: georg.brandl - brett.cannon
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7829
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com