[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Mathew Martineau]

Mathew Martineau  added the comment:

I can submit a patch, but my employer has an involved process for doing this 
(even for small fixes like this).  It will take a few more days to get to a 
point where I can post the patch, but I will do so as soon as I can.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Yaniv Aknin]

Yaniv Aknin  added the comment:

I wouldn't mind producing the patch, if Mathew is OK with this.

--
nosy: +Yaniv.Aknin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Mathew Martineau]

Mathew Martineau  added the comment:

Yaniv - Please proceed!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Antoine Pitrou]

Antoine Pitrou  added the comment:

By the way, even better if you find a way of having unit tests for bluetooth 
sockets. Is there some kind of "dummy" device which gives predictable results 
(à la /dev/zero, for example)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Yaniv Aknin]

Yaniv Aknin  added the comment:

I've zero experience with programming bluetooth (to be honest, I only tackled 
this bug because I'm learning how to contribute to Python and it seemed 
ultra-easy), so I'm not an authoritative source on whether such a 'loopback' 
test is possible.

On #bluez in freenode I was told that generally no, there is no 'localhost' for 
BT sockets, and that a while ago there was a bluetooth emulation tool called 
'hciemu' which is no longer maintained.

I'm attaching the patch (it's just a oneliner), it passes regression though 
obviously isn't really tested by it... I suggest Mathew will try the patch out 
and see if it helps; we can decide how to proceed from there.

--
keywords: +patch
Added file: http://bugs.python.org/file16799/zero_l2cap_addr_struct.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Committed in r80610. Thanks!

--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Mathew Martineau]

New submission from Mathew Martineau :

The sockaddr_l2 struct used with connect() has changed in recent versions of 
the Linux kernel.  There is a new l2_cid member.

connect() only works with L2CAP sockets if l2_cid is set to 0.

Suggest initializing the whole sockaddr_l2 struct to 0 in getsockaddrarg() 
(socketmodule.c).

--
components: Extension Modules
messages: 98700
nosy: Mathew.Martineau
severity: normal
status: open
title: socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets
type: behavior
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7834] socket.connect() no longer works with AF_BLUETOOTH L2CAP sockets

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Could you produce a patch?

--
keywords: +easy
nosy: +pitrou
priority:  -> normal
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com