[issue7883] CallTips.py _find_constructor does not work
Terry J. Reedy added the comment: THanks for reporting this. #12520 tripled the number of tests in CallTips.py and #20122 moved them to test_calltips.py. I think they cover this case and the tests proposed. #16630 added a few more tests and patched CallTips.py to make them pass. If you find any other cases that fail with the current bugfix releases, report them on a new issue. -- assignee: - terry.reedy resolution: fixed - out of date stage: test needed - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Terry J. Reedy added the comment: The 3.x changes will not affect 2.7, which currently still uses _find_constructor. I suspect the .__func__ is needed for old-style classes, but I will try to check. -- versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Move CallTips tests to idle_tests ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Terry J. Reedy added the comment: #12520 deleted _find_constructor in 3.x as it works with, but only with old-style classes (gone in 3.x) and just uses getattr(ob, '__init__', None). I believe the tests in this patch duplicate existing tests at the bottom of CallTips.py (increased from 10 to 30 as part of #12510). I will recheck when I move the existing tests into the new idle_test/test_calltips.py. -- versions: +Python 2.7 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Changes by Brian Curtin br...@python.org: -- nosy: -brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Roger Serwy roger.se...@gmail.com added the comment: Issue12510 fixes the issues listed here. I am leaving this issue open for discussing the test provided by Bernt. -- nosy: +terry.reedy resolution: - fixed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Bernt Røskar Brenna bernt.bre...@gmail.com added the comment: Attached is Lib/test/test_idlelib.py, containing a unit test for the issue. -- Added file: http://bugs.python.org/file24075/test_idlelib.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Roger Serwy roger.se...@gmail.com added the comment: The patch works for me as well against 3.3a0. Are there any cases where __init__.__func__ would work? -- nosy: +serwy versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
New submission from Bernt Røskar Brenna bernt.bre...@gmail.com: Test case: In IDLE python shell: from http.client import HTTPConnection c = HTTPConnection( Notice that the call tip is an empty parenthesis. This patch works for me: [/tmp/py3k/Lib/idlelib] $ svn diff Index: CallTips.py === --- CallTips.py (revision 78103) +++ CallTips.py (working copy) @@ -116,7 +116,7 @@ def _find_constructor(class_ob): Find the nearest __init__() in the class tree. try: -return class_ob.__init__.__func__ +return class_ob.__init__ except AttributeError: for base in class_ob.__bases__: init = _find_constructor(base) -- components: IDLE messages: 99043 nosy: Bernt.Røskar.Brenna severity: normal status: open title: CallTips.py _find_constructor does not work type: behavior versions: Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7883] CallTips.py _find_constructor does not work
Brian Curtin cur...@acm.org added the comment: That change works for me. -- nosy: +brian.curtin priority: - normal stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7883 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
