[issue8086] ssl.get_server_certificate new line missing

2010-04-27 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

This looks reasonable enough.

--
nosy: +pitrou
stage: unit test needed - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-04-27 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Fixed in r80557 (trunk) and r80558 (2.6). 3.1 and 3.2 weren't affected, but I 
still merged in the additional tests. Thank you!

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-26 Thread Kyle VanderBeek 

Changes by Kyle VanderBeek ky...@kylev.com:


--
keywords: +patch
Added file: http://bugs.python.org/file16672/python-ssl-PEM_FOOTER.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-26 Thread Kyle VanderBeek 

Kyle VanderBeek ky...@kylev.com added the comment:

Forgot to note that my patch is against 2.7 current trunk.

--
nosy: +kylev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-07 Thread Chris 

New submission from Chris chris...@gmail.com:

I'm using ssl.get_server_certificate function. It returns a pem string. For 
each server I try, I get the string, but it is missing a newline \n before 
the -END CERTIFICATE- text. Any subsequent use of the string makes 
openssl throw up with a bad end line error.

ssl.PEM_cert_to_DER_cert can be used, and, subsequently the der string can be 
used elsewhere.

Example:
 fncert = ssl.get_server_certificate((freenode.net, 443), 3)
 fncert
'-BEGIN 
CERTIFICATE-\nMIICFTCCAX6gAwIBAgIBAjANBgkqhkiG9w0BAQUFADBVMRswGQYDVQQKExJBcGFj\naGUgSFRUUCBTZXJ2ZXIxIjAgBgNVBAsTGUZvciB0ZXN0aW5nIHB1cnBvc2VzIG9u\nbHkxEjAQBgNVBAMTCWxvY2FsaG9zdDAeFw0wNzA1MDkxODM2MjVaFw0wODA1MDgx\nODM2MjVaMEwxGzAZBgNVBAoTEkFwYWNoZSBIVFRQIFNlcnZlcjEZMBcGA1UECxMQ\nVGVzdCBDZXJ0aWZpY2F0ZTESMBAGA1UEAxMJbG9jYWxob3N0MIGfMA0GCSqGSIb3\nDQEBAQUAA4GNADCBiQKBgQDYqJO6X9uwU0AyJ6H1WgYCZOqpZvdI96/LaDumT4Tl\nD6QvmXzAbM4okSHU3FEuSqR/tNv+eT5IZJKHVsXh0CiDduIYkLdqkLhEAbixjX/1\nfdCtGL4X0l42LqhK4TMFT5AxxsP1qFDXDvzl/yjxo9juVuZhCeqFr1YDKBffCIAn\ncwIDAQABMA0GCSqGSIb3DQEBBQUAA4GBAG0zi/KyzHxSsLHfrwTFh9330TaGj/3H\nuvhmBUPC3FOxbIH2y5CG/Ddg46756cfaxKKiqJV3I4dAgatQybE65ELc3wOWgs4v\n4VDGsFKbkmBLuCgnFaY+p4xvr2XL+bJmpm8+IQqW5Ob/OUSl7Vj4btHhF6VK29CI\n+DexDLRI0KqZ-END
 CERTIFICATE-\n'

Notice no \n before -END CERTIFICATE-\n

Platform: 
Linux x64
python 2.6.4

--
messages: 100595
nosy: offero
severity: normal
status: open
title: ssl.get_server_certificate new line missing
type: behavior
versions: Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-07 Thread Chris 

Chris chris...@gmail.com added the comment:

Did some more research and found this as the culprit:

in Lib/ssl.py

#
...
def get_server_certificate(addr, ssl_version=PROTOCOL_SSLv3, ca_certs=None):
...
return DER_cert_to_PEM_cert(dercert)

def DER_cert_to_PEM_cert(der_cert_bytes):

Takes a certificate in binary DER format and returns the
PEM version of it as a string.

if hasattr(base64, 'standard_b64encode'):
# preferred because older API gets line-length wrong
f = base64.standard_b64encode(der_cert_bytes)
return (PEM_HEADER + '\n' +
textwrap.fill(f, 64) +
PEM_FOOTER + '\n')
else:
return (PEM_HEADER + '\n' +
base64.encodestring(der_cert_bytes) +
PEM_FOOTER + '\n')



Notice no '\n' before the PEM_FOOTER

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-07 Thread R. David Murray 

R. David Murray rdmur...@bitdance.com added the comment:

I think that's because encodestring tacks a 'courtesy newline' on to the end of 
the output it returns.  textwrap.fill does't, and I'm guessing that's the code 
path that your installation is taking.

--
components: +Library (Lib)
keywords: +easy
nosy: +r.david.murray
priority:  - normal
stage:  - test needed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-07 Thread R. David Murray 

Changes by R. David Murray rdmur...@bitdance.com:


--
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8086] ssl.get_server_certificate new line missing

2010-03-07 Thread R. David Murray 

Changes by R. David Murray rdmur...@bitdance.com:


--
nosy: +janssen

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com