[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-19 Thread Benjamin Peterson 

Changes by Benjamin Peterson benja...@python.org:


--
assignee:  - brett.cannon
priority:  - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-18 Thread Ned Deily 

Ned Deily n...@acm.org added the comment:

Test failing on 3.1.2rc1.  Should this be considered a release blocker?  
Perhaps just disable temporarily?

--
nosy: +benjamin.peterson, ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-16 Thread Mark Dickinson 

Mark Dickinson dicki...@gmail.com added the comment:

Brett:  any thoughts on this?  Should imp.find_module automatically apply NFD 
normalization to the given string on OS X?

It seems to me that doing this properly is a bit nasty, since the correct 
condition isn't that the OS is OS X, but that the relevant filesystem is HFS+;  
presumably a single call to imp.find_module could end up checking directories 
with differing filesystems.

--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-16 Thread Brett Cannon 

Brett Cannon br...@python.org added the comment:

Trying to get this right is nasty as mixed filesystem stuff is always tricky, 
especially since NFD is still UTF-8 as is NFC so sys.getdefaultencoding() 
doesn't help.

Without some way to get that extra bit of info about what form of UTF-8 
encoding is being used for the filesystem, I think the test should be modified 
to use os.listdir() to find the name as encoded by the filesystem and use that 
as the argument to imp.find_module() instead of assuming the filesystem didn't 
tweak what it was given.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-13 Thread Mark Dickinson 

New submission from Mark Dickinson dicki...@gmail.com:

test_issue5604 from test_imp is currently failing on OS X !0.6 (py3k branch), 
with the following output:

==
ERROR: test_issue5604 (__main__.ImportTests)
--
Traceback (most recent call last):
  File Lib/test/test_imp.py, line 121, in test_issue5604
file, filename, info = imp.find_module(temp_mod_name)
ImportError: No module named test_imp_helper_ä

--


I think this has something to do with the platform automatically
using NFD normalization for filenames.  Here's an interactive session: 

Python 3.2a0 (py3k:78936, Mar 13 2010, 19:42:52) 
[GCC 4.2.1 (Apple Inc. build 5646) (dot 1)] on darwin
Type help, copyright, credits or license for more information.
 import imp, unicodedata
 fname = 'test' + b'\xc3\xa4'.decode('utf-8')
 with open(fname+'.py', 'w') as file: file.write('a = 1\n')
... 
6
 imp.find_module(fname)   # expected this to succeed
Traceback (most recent call last):
  File stdin, line 1, in module
ImportError: No module named testä
 imp.find_module(unicodedata.normalize('NFD', fname))
(_io.TextIOWrapper name=4 encoding='utf-8', 'testä.py', ('.py', 'U', 1))


In contrast, a simple 'open' doesn't seem to care about normalization:

 open(fname+'.py')
_io.TextIOWrapper name='testä.py' encoding='UTF-8'
[50305 refs]
 open(unicodedata.normalize('NFD', fname)+'.py')
_io.TextIOWrapper name='testä.py' encoding='UTF-8'
[50305 refs]

--
messages: 101018
nosy: ezio.melotti, mark.dickinson
severity: normal
status: open
title: test_imp fails on OS X 10.6; filename normalization issue.
type: behavior
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8133] test_imp fails on OS X 10.6; filename normalization issue.

2010-03-13 Thread Mark Dickinson 

Mark Dickinson dicki...@gmail.com added the comment:

Also affects 3.1.

--
versions: +Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com