[issue8405] Improve test_os._kill (failing on slow machines)
Brian Curtin cur...@acm.org added the comment: Committed to trunk in r81584 and py3k in r81585. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8405] Improve test_os._kill (failing on slow machines)
STINNER Victor victor.stin...@haypocalc.com added the comment: Committed to trunk in r81584 and py3k in r81585 sparc solaris10 gcc trunk buildbot slave doesn't compile anymore. I'm not sure that it's related, so I prefer to not reopen the issue :-) http://www.python.org/dev/buildbot/trunk/builders/sparc%20solaris10%20gcc%20trunk/builds/891 --- ... building '_struct' extension gcc -fPIC -fno-strict-aliasing -g -O2 -g -O0 -Wall -Wstrict-prototypes -I. -IInclude -I./Include -I/usr/local/include -I/home2/buildbot/slave/trunk.loewis-sun/build/Include -I/home2/buildbot/slave/trunk.loewis-sun/build -c /home2/buildbot/slave/trunk.loewis-sun/build/Modules/_struct.c -o build/temp.solaris-2.10-sun4u-2.7-pydebug/home2/buildbot/slave/trunk.loewis-sun/build/Modules/_struct.o gcc -shared build/temp.solaris-2.10-sun4u-2.7-pydebug/home2/buildbot/slave/trunk.loewis-sun/build/Modules/_struct.o -L/usr/local/lib -o build/lib.solaris-2.10-sun4u-2.7-pydebug/_struct.so Assertion failed: min = 0, file Python/getargs.c, line 1826 *** Error code 134 The following command caused the error: case $MAKEFLAGS in \ *s*) CC='gcc' LDSHARED='gcc -shared' LDFLAGS='' OPT='-g -O0 -Wall -Wstrict-prototypes' ./python -E ./setup.py -q build;; \ *) CC='gcc' LDSHARED='gcc -shared' LDFLAGS='' OPT='-g -O0 -Wall -Wstrict-prototypes' ./python -E ./setup.py build;; \ esac make: Fatal error: Command failed for target `sharedmods' program finished with exit code 1 --- -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8405] Improve test_os._kill (failing on slow machines)
Brian Curtin cur...@acm.org added the comment: I just noticed the other day that a buildbot failed because of this issue. Attached is a patch which removes the unconditional 0.5 sleep, and increases the loop to run 100 times. It should cover the worst case of a super slow buildbot, but is still typically complete in tenths of a second in the common case. -- Added file: http://bugs.python.org/file17473/issue8405.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8405] Improve test_os._kill (failing on slow machines)
STINNER Victor victor.stin...@haypocalc.com added the comment: With the patch, the test have 1.0 second to succeed. I would prefer 5.0 or 10.0 seconds: it should not waste the 10 seconds because it should succeed if a new milliseconds. But if the machine is slow (which is the topic of the issue), you can give some more seconds to the test. So max=100, sleep=0.1 -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8405] Improve test_os._kill (failing on slow machines)
R. David Murray rdmur...@bitdance.com added the comment: I like this version of the patch better. Is there any reason not to drop the initial sleep(0.5) and loop 10 times instead? Any place we can cut down the sleeps so the test suite runs faster on fast machines is good. As someone else said, it *ought* to be possible to do this without ctypes. I'll see if I can find some time to play a few subprocess games on my windows KVM instance. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8405] Improve test_os._kill (failing on slow machines)
New submission from Brian Curtin cur...@acm.org: test_os._kill is used by test_kill_sigterm and test_kill_int and is failing on a slow Windows buildbot due to timing issues between the process starting and the signal being sent. I've checked in a few small time.sleep hacks in the meantime to see if that would help the bot, but I'd like to get a solid fix in there. The attached patch adds a loop to the test function to see that even if the subprocess doesn't respond right away, it will have a few chances to respond and run the test. If the expected message isn't piped from the subprocess after 5 retries, the test fails. -- assignee: brian.curtin components: Library (Lib), Windows files: fix_test_os.diff keywords: patch messages: 103179 nosy: brian.curtin priority: normal severity: normal stage: patch review status: open title: Improve test_os._kill (failing on slow machines) type: behavior versions: Python 2.7, Python 3.2 Added file: http://bugs.python.org/file16928/fix_test_os.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8405 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
