[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
STINNER Victor victor.stin...@haypocalc.com added the comment: I commited the fix on _ssl._test_decode_cert() as r81237 (py3k, blocked in 3.1: r81238). Issue #8550 got accepted and uses PyUnicode_FSConverter for the filenames (except _ssl._test_decode_cert() which is now fixed). -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
STINNER Victor victor.stin...@haypocalc.com added the comment: Oh, I forgot to patch RAND_egd()! Fixed: r81239 (py3k, blocked in 3.1: r81240). The whole ssl module should now be fully str+surrogates/bytes filenames compliant :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
Antoine Pitrou pit...@free.fr added the comment: Most of this should be solved if the patch in issue8550 gets accepted. As for test_decode_certificate, it seems it isn't used anywhere, and could therefore be deleted. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
STINNER Victor victor.stin...@haypocalc.com added the comment: key_file and cert_file are mandatory (see newPySSLObject()) and bytearray are now more accepted by PyUnicode_FSConverter() (see #8485). New version of the patch is simpler and shorter. Support bytearray is a little bit to much complex for me (because of the GIL and bytearray lock), I prefer to leave 3.1 unchanged (I will not backport this patch). -- Added file: http://bugs.python.org/file17051/ssl_surrogates-2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
Changes by STINNER Victor victor.stin...@haypocalc.com: Removed file: http://bugs.python.org/file17017/ssl_surrogates.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
Antoine Pitrou pit...@free.fr added the comment: key_file and cert_file are mandatory No, they are not. Not for a client connection, at least. Also, please add at least a simple test. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
New submission from STINNER Victor victor.stin...@haypocalc.com: _ssl.sslwrap() has 3 filename arguments: key_file, cert_file and cacerts_file. It uses z format to parse them. Attached patch uses PyUnicode_FSConverter() to support surrogates, bytes and bytearray. It fixes also test_decode_certificate() function. -- components: Library (Lib), Unicode files: ssl_surrogates.patch keywords: patch messages: 103793 nosy: haypo severity: normal status: open title: _ssl: support surrogates in filenames, and bytes/bytearray filenames versions: Python 2.7, Python 3.2 Added file: http://bugs.python.org/file17017/ssl_surrogates.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8477] _ssl: support surrogates in filenames, and bytes/bytearray filenames
Antoine Pitrou pit...@free.fr added the comment: Some comments: - your ssl_convert_filename() function has a strange signature - using PyByteArray_AsString() is wrong, we release the GIL later and the buffer could be reallocated, leading to a crash; the right approach is to use PyObject_GetBuffer() and later PyBuffer_Release() - as such, your function could simply return the bytes/bytearray PyObject *, and not fill the char * pointer - adding tests for both the bytes and unicode cases would be nice -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8477 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
