[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Berker Peksag]

Berker Peksag  added the comment:

Thank you for doing issue triage, Masayuki!

--
nosy: +berker.peksag
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Masayuki Yamamoto]

Masayuki Yamamoto  added the comment:

This issue has been out-of-date since Python 3.4 maintenance became security 
status.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

This issue resolved on default branch in #20597 .

In 3.4 branch latest, PATH_MAX seems unused already in Modules/main.c:12 and 
Python/pythonrun.c:35.
I want to cherry-pick #20597 to 3.4 branch.

--
nosy: +masamoto

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Roumen Petrov]

Roumen Petrov added the comment:

Hi Mark,
#else before is not solution. See  unified diff below as post by Scott Rostrup 
lack definition

Some additional information:
a) move outside #ifdef HAVE_FCNTL_H : definition PATH_MAX is not related to 
control functions on open files (fcntl.h)
b) HAVE_FCNTL_H is defined for MSC build as well. so no impact on other build

--- a/Modules/main.c
+++ b/Modules/main.c
@@ -9,6 +9,8 @@
 #include windows.h
 #ifdef HAVE_FCNTL_H
 #include fcntl.h
+#endif
+#ifndef PATH_MAX
 #define PATH_MAX MAXPATHLEN
 #endif
 #endif
--

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Mark Lawrence]

Mark Lawrence added the comment:

main.c has this.

#if defined(MS_WINDOWS) || defined(__CYGWIN__)
#include windows.h
#ifdef HAVE_FCNTL_H
#include fcntl.h
#define PATH_MAX MAXPATHLEN
#endif
#endif

Wouldn't inserting #else before #define fix this issue?

--
components: +Build -Installation, Windows
nosy: +BreamoreBoy, jlt63, stutzbach
versions: +Python 3.4, Python 3.5 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Roumen Petrov]

Changes by Roumen Petrov bugtr...@roumenpetrov.info:


--
nosy: +rpetrov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
components: +Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
nosy:  -terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Nicholas DiPiazza]

Nicholas DiPiazza nicholas.dipia...@gmail.com added the comment:

In Python3.1.2-src/Modules/main.c

I actually had to use this to get it to work:

#if defined(MS_WINDOWS) || defined(__CYGWIN__)
#include windows.h
#ifdef HAVE_FCNTL_H
#include fcntl.h
#endif
#ifndef HAVE_FCNTL_H
#define PATH_MAX MAXPATHLEN
#endif
#endif

--
nosy: +Nicholas.DiPiazza

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Scott Rostrup]

Scott Rostrup scott.rost...@googlemail.com added the comment:

I just encountered this error in python 3.1.3 on cygwin 1.7.
I used the same fix as jbinder.

Old Modules/main.c (line 13):

  #if defined(MS_WINDOWS) || defined(__CYGWIN__)
  #include windows.h
  #ifdef HAVE_FCNTL_H
  #include fcntl.h
  #define PATH_MAX MAXPATHLEN
  #endif
  #endif

I guess now cygwin is defining PATH_MAX, one possible fix with ifndef:

  #if defined(MS_WINDOWS) || defined(__CYGWIN__)
  #include windows.h
  #ifdef HAVE_FCNTL_H
  #include fcntl.h
  #ifndef
  #define PATH_MAX MAXPATHLEN
  #endif
  #endif
  #endif

This compiled and worked for me and it appears jbinder as well.

--
nosy: +Scott.Rostrup
Added file: http://bugs.python.org/file20155/py_cygwin_build-3.1.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Florent Xicluna]

Changes by Florent Xicluna florent.xicl...@gmail.com:


--
components: +Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Terry J. Reedy]

Terry J. Reedy tjre...@udel.edu added the comment:

None of the developers are much up on Cygwin and I am not sure it is directly 
supported by the core distribution. If it is not, this should be closed unless 
you have a specific patch.

In any case, you might do better with your question on python-list. Also, PEP11 
list Jason Tishler (ja...@tishler.net) as Cygwin maintainer.

Next time, please attach an edited, plain-text .txt log that can be viewed in 
the browser. I would have to be really motivated to download and extract a 
tar.gz file.

--
nosy: +terry.reedy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8548] Building on CygWin 1.7: PATH_MAX redefined

[Jeff Binder]

New submission from Jeff Binder extru...@gmail.com:

Building Python 3.1.2 on Cygwin 1.7, I got errors in main.c stemming from a 
warning: PATH_MAX redefined (see attached log).  I got around this by 
commenting out the #define.  I don't know if the best solution is #ifndef, 
#undef, or something else. . . . I know CygWin has changed the value of 
PATH_MAX in 1.7 (see: http://www.cygwin.com/cygwin-ug-net/ov-new1.7.html), 
though I'm not sure why that would cause this problem.

--
components: Installation
files: python-build-logs.tar.gz
messages: 104334
nosy: jbinder
priority: normal
severity: normal
status: open
title: Building on CygWin 1.7: PATH_MAX redefined
type: compile error
versions: Python 3.1
Added file: http://bugs.python.org/file17107/python-build-logs.tar.gz

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8548
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com