[issue8682] _ssl.c uses PyWeakref_GetObject but doesn't incref result

2010-06-24 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Here is a patch. Will commit soon if there's no remarks.

--
keywords: +patch
nosy: +exarkun, giampaolo.rodola, janssen
Added file: http://bugs.python.org/file17761/sslweakref.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8682
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8682] _ssl.c uses PyWeakref_GetObject but doesn't incref result

2010-06-24 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Committed in r82204 (py3k) and r82205 (3.1).

--
resolution:  - fixed
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8682
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8682] _ssl.c uses PyWeakref_GetObject but doesn't incref result

2010-05-10 Thread Antoine Pitrou

New submission from Antoine Pitrou pit...@free.fr:

PyWeakref_GetObject() returns a borrowed reference, which can therefore become 
invalid at any time (especially when the GIL gets released). This provides a 
way to crash the interpreter deliberately.
The returned reference should be incref'ed immediately before any other action 
is taken.

--
assignee: pitrou
components: Extension Modules
messages: 105481
nosy: pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: _ssl.c uses PyWeakref_GetObject but doesn't incref result
type: crash
versions: Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8682
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com