[issue8749] Cruft in object.c: PyObject_GenericGetAttr

[Mark Dickinson]

Mark Dickinson dicki...@gmail.com added the comment:

Fixed in r81470.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8749] Cruft in object.c: PyObject_GenericGetAttr

[Yaniv Aknin]

New submission from Yaniv Aknin yaniv.ak...@gmail.com:

While reading the source I saw that recent py3k has this in Objects/object.c 
(reasonably recent trunk has it as well):

#if 0 /* XXX this is not quite _PyType_Lookup anymore */
/* Inline _PyType_Lookup */
{ ... removed ...
}
#else
descr = _PyType_Lookup(tp, name);
#endif

This was commented out (on trunk, I assumed on py3k it was for the same reason) 
by amaury.forgeotdarc on revision 59943, when a patch to the real 
_PyType_Lookup was applied.

I think it can be safely removed.

--
components: Interpreter Core
messages: 105967
nosy: Yaniv.Aknin
priority: normal
severity: normal
status: open
title: Cruft in object.c: PyObject_GenericGetAttr
versions: Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8749] Cruft in object.c: PyObject_GenericGetAttr

[Mark Dickinson]

Changes by Mark Dickinson dicki...@gmail.com:


--
nosy: +mark.dickinson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8749] Cruft in object.c: PyObject_GenericGetAttr

[Mark Dickinson]

Mark Dickinson dicki...@gmail.com added the comment:

Looks like r59944 to me.

Amaury, any objections to removing this '#if 0' code?

--
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8749] Cruft in object.c: PyObject_GenericGetAttr

[Yaniv Aknin]

Yaniv Aknin yaniv.ak...@gmail.com added the comment:

Oops, of course I meant r59944, off by one. :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8749
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com