[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Stefano Taschini  added the comment:

Understood and agreed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Martin v . Löwis]

Changes by Martin v. Löwis :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Martin v . Löwis]

Martin v. Löwis  added the comment:

Thanks for the patch. I did the library patch without monkey-patching.

If there are further issues with this feature, please submit new bug reports. I 
won't consider the many test failures due to usage of Unicode literals in the 
test cases as bugs, as working around for the lack of Unicode literals is quite 
tedious, and would reduce readability.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Roundup Robot]

Roundup Robot  added the comment:

New changeset d7aff4423172 by Martin v. Löwis in branch '2.7':
Issue #8767: Restore building with --disable-unicode.
http://hg.python.org/cpython/rev/d7aff4423172

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Stefano Taschini  added the comment:

Here we go.

--
Added file: http://bugs.python.org/file25419/issue8767_stdlib.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Changes by Stefano Taschini :


Added file: http://bugs.python.org/file25418/issue8767_interpreter.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Martin v . Löwis]

Martin v. Löwis  added the comment:

>  it might be better to split the issue (and the patch) into two: one for the 
> autoconf and interpreter, and one for the stdlib.

Please do that. Splitting the patch could be enough, no need to split 
the issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Stefano Taschini  added the comment:

Martin,

That was exactly my first approach. What made me change my mind is that 

   i) it is also fairly hacky (one might rightfully object that it is the 
isinstance(x, unicode) tests that should be changed)

   ii) it is now a hack spread over a dozen files, instead of the site.py alone.

   iii) the alterations in those files are executed even in the case of 
built-in unicode support, thus increasing the risk of introducing a regression 
in the stdlib.

In the end I was a bit loath to alter quite a few of the stdlib modules 
(including some of the "core" ones) for a rather infrequent case. My solution, 
on the other hand, is such that in the regular case of built-in unicode support 
those modules are not touched at all, thus reducing the risk of introducing a 
regression in the stdlib.

Still, if you guys do think that the maintainability risk due to the hackiness 
of my suggestion exceeds the potential benefits, it might be better to split 
the issue (and the patch) into two: one for the autoconf and interpreter, and 
one for the stdlib. In this way, the patch for autconf and interpreter (which 
should be less controversial) might be accepted sooner, while we bide our time 
until we come up with a better solution for the stdlib.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Martin v . Löwis]

Martin v. Löwis  added the comment:

I find the injection of a fake unicode class too hacky. Instead, I suggest that 
each module does

try:
_unicode = unicode
except NameError:
# no unicode support in this build
class _unicode:
pass

and then have the isinstance checks look for _unicode

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Stefano Taschini  added the comment:

Here's the patch. It has four goals:

   1. Allow ./configure --disable-unicode to work;

   2. Have the naked interpreter running with no unicode support;

   3. Be able to compile most of the stdlib;

   4. Be able to run the test suite.

The one-line modification to configure.ac (and consequentley autoreconf'ed 
configure) achieve goal 1.

The changes to the three C files (which are nothing more than a few #ifdef 
Py_USING_UNICODE) achieve goal 2: you can run "./python -S".

The fix for site.py takes care of posixpath, glob, (and a few other modules) 
and makes it possible to compile most of the C extensions of the stdlib, goal 3 
-- The compilation process under posix requires posixpath and glob to work.  
The most notable extension that won't be built is, unsurprisingly enough, io. 
Fortunately it does not play in Python 2.7 the central role it plays in Python 
3. Still, a few other modules depend on it and won't be usable.

The changes in Lib/test/script_helper.py and Lib/test/test_support.py make it 
possible to run the test suite. Roughly one third of the tests will fail, 
though, but I think that's acceptable. In relation to my purpose for submitting 
this patch ( #1065986 ) , I note that test_pydoc runs and succeeds.

--
keywords: +patch
Added file: http://bugs.python.org/file25377/issue8767.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[R. David Murray]

R. David Murray  added the comment:

Reopening per this python-dev thread where MvL said that not being able to 
build 2.7 without unicode is a bug (but someone would need to care enough to 
contribute a patch to fix it).

--
nosy: +r.david.murray
priority: normal -> low
stage:  -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Stefano Taschini]

Changes by Stefano Taschini :


--
nosy: +taschini

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Charles Solar]

Changes by Charles Solar :


Removed file: http://bugs.python.org/file17403/config.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Charles Solar]

Charles Solar  added the comment:

Seems as though python 2.7 should not support --disable-unicode so this ticket 
is invalid.  I just googled python disable unicode, but it seems that the 
decision to never disable unicode is recent.
Closing

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8767] Configure: Cannot disable unicode

[Charles Solar]

New submission from Charles Solar :

I am compiling python on AIX 5.3.  The normal configure and make works, except 
it fails to compile the unicodedata module.  The assembler reports a bunch of 
these errors:
Error: value of 0001268b too large for field of 2 bytes at 
006d

The module is labeled as optional, but if that one fails python will not 
install.  One of the .py files it tries to compile requires unicodedata so the 
whole thing fails.

I tried --enable-unicode=ucs4 and got the same results so then I tried just 
--disable-unicode all together and configure spits out: 
checking what type to use for unicode... configure: error: invalid value for 
--enable-unicode. Use either ucs2 or ucs4 (lowercase).

I had to go into the configure script itself remove a default case statement 
that produced the error to disable it completely.

Building Python2.7b1 on AIX 5.3

--
components: Build
files: config.log
messages: 106076
nosy: redcomet
priority: normal
severity: normal
status: open
title: Configure: Cannot disable unicode
type: compile error
versions: Python 2.7
Added file: http://bugs.python.org/file17403/config.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com