[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[STINNER Victor]

STINNER Victor victor.stin...@haypocalc.com added the comment:

There is another error:

test test_ssl failed -- Traceback (most recent call last):
  File 
/scratch/pybot-buildarea/trunk.klose-ubuntu-i386/build/Lib/test/test_ssl.py, 
line 261, in test_algorithms
s.connect(remote)
  File /scratch/pybot-buildarea/trunk.klose-ubuntu-i386/build/Lib/ssl.py, 
line 292, in connect
socket.connect(self, addr)
  File /scratch/pybot-buildarea/trunk.klose-ubuntu-i386/build/Lib/socket.py, 
line 222, in meth
return getattr(self._sock,name)(*args)
error: [Errno 110] Connection timed out

transient_internet() should also catch socket.error(errno.ETIMEDOUT).

--

See also #8455, #8499 and #8574.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

 I commited the patch as r81571 in trunk.

Apparently it's ok.

--
assignee:  - haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[STINNER Victor]

New submission from STINNER Victor victor.stin...@haypocalc.com:

The nameserver responsible of sha2.hboeck.de is down and this hostname is used 
in test_ssl. The result is that all trunk buildbots are red (error).

support.transient_internet() should catch socket.gaierror.

--

One example: 
http://www.python.org/dev/buildbot/all/builders/amd64%20gentoo%20trunk/builds/1007

Traceback (most recent call last):
  File .../Lib/test/test_ssl.py, line 261, in test_algorithms
s.connect(remote)
  ...
gaierror: [Errno -2] Name or service not known

--
components: Tests
messages: 106617
nosy: haypo
priority: normal
severity: normal
status: open
title: buildbot: support.transient_internet() doesn't catch DNS socket.gaierror
versions: Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[STINNER Victor]

STINNER Victor victor.stin...@haypocalc.com added the comment:

Patch to catch gaierror(EAI_NODATA) and gaierror(EAI_NONAME).

--
keywords: +patch
Added file: http://bugs.python.org/file17477/transilient_internet_dns.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

Looks ok to me.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8835] buildbot: support.transient_internet() doesn't catch DNS socket.gaierror

[STINNER Victor]

STINNER Victor victor.stin...@haypocalc.com added the comment:

I commited the patch as r81571 in trunk. Wait for the buildbot before porting 
it to other branches.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8835
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com