[issue9075] ssl module sets debug flag on SSL struct
Changes by Sridhar Ratnakumar sridh...@activestate.com: -- nosy: +srid ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9075] ssl module sets debug flag on SSL struct
New submission from Antoine Pitrou pit...@free.fr: The ssl module sets a debug flag on the OpenSSL SSL struct at the end of PySSL_SSLdo_handshake(): self-ssl-debug = 1; The OpenSSL header files have this to say about this flag: /* set this flag to 1 and a sleep(1) is put into all SSL_read() * and SSL_write() calls, good for nbio debuging :-) */ int debug; Some uses of it in the OpenSSL source are actually guarded by a macro (#ifdef PKT_DEBUG), but some are not. Bill, do you remember why you put that call? I would find it strongly preferrable to remove that assignment (doing so doesn't seem to break anything in the test suite). -- components: Library (Lib) messages: 108561 nosy: exarkun, giampaolo.rodola, janssen, pitrou priority: high severity: normal status: open title: ssl module sets debug flag on SSL struct type: behavior versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9075] ssl module sets debug flag on SSL struct
Antoine Pitrou pit...@free.fr added the comment: Actually, looking at the history of the SVN repo, this dates back to 1999 when the first SSL support was incorporated by Guido based on third-party patches, and no trace of a review discussion can be found. The only thing we can do is assume it's useless (and perhaps detrimental to performance) and remove it now. Benjamin, do you think it's safe for 2.7 or should wait for 2.7.1? -- nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9075] ssl module sets debug flag on SSL struct
Benjamin Peterson benja...@python.org added the comment: Let it die. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9075] ssl module sets debug flag on SSL struct
Antoine Pitrou pit...@free.fr added the comment: Thanks! Committed in r82210 (trunk), r82211 (py3k), r82212 (2.6), r82213 (3.1). -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9075 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
