[issue9095] patchcheck should handle extraneous whitespace in .rst files
Éric Araujo mer...@netwok.org added the comment: I tried to use “make patchcheck” after edits to reST files and it hung. Do you have the same behavior? I suspect reindent-rst is the culprit. I’m wondering about the reindenting; other checks in patchcheck don’t edit files, they just print warnings. On the other hand, removing trailing whitespace and reindenting is not a very good use of people’s time, so having a tool do them is good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Brett Cannon br...@python.org added the comment: Just ran it without issue after doing an `svn up`. As for fix vs. not, while fixing indentations and removing trailing whitespace is nice, it isn't necessary. Both instances should be a rarity (most IDEs will make sure the situation doesn't occur), so the most important thing is detecting there is an issue for people to fix them (along with providing as much info as possible to make it easy to fix) rather than fixing it for them (if that turns out to be somewhat complicated to do). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Georg Brandl ge...@python.org added the comment: patchcheck.py is not so complicated; why don't you debug that hangup yourself? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Georg Brandl ge...@python.org added the comment: Now done in r85767. -- dependencies: -`make patchcheck` should check the whitespace of .c/.h files nosy: +georg.brandl status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Éric Araujo mer...@netwok.org added the comment: Please apply the refactor patch in #8912 -- dependencies: +`make patchcheck` should check the whitespace of .c/.h files versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Éric Araujo mer...@netwok.org added the comment: Feel free to assign patchcheck bugs to me. I’ll write a patch and then assign to you for review. -- nosy: +merwok resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
Brett Cannon br...@python.org added the comment: Knock yourself out! -- assignee: - merwok ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9095] patchcheck should handle extraneous whitespace in .rst files
New submission from Brett Cannon br...@python.org: Tools/scripts/reindent-rst.py already exists, so this should be simple to add. -- components: Demos and Tools keywords: easy messages: 108808 nosy: brett.cannon priority: low severity: normal stage: needs patch status: open title: patchcheck should handle extraneous whitespace in .rst files type: feature request ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9095 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
