[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Éric Araujo]

Éric Araujo  added the comment:

Can this be backported, or just closed?

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Thank you, I've committed in r84993(py3k)
I'll close this issue after merging to other branches.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I'm not really able to review this kind of things. Please commit if you think 
it is ok.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


Added file: http://bugs.python.org/file18995/py3k_better_build_ssl.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


Removed file: http://bugs.python.org/file18992/py3k_better_build_ssl.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


Removed file: http://bugs.python.org/file18974/py3k_better_build_ssl.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Sorry, previous one contained experimental code for another issue.
I've attached correct one.

--
Added file: http://bugs.python.org/file18992/py3k_better_build_ssl.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

- Module/_ssl.c or Module/_hashlib.c are rebuilt
+ Module/_ssl.c or Module/_hashlib.c won't be rebuilt

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


--
resolution: fixed -> 
status: closed -> open
versions: +Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Hello. Probably I found the better solution for this issue.

* build_ssl.py always runs before _ssl.vcproj or _hashlib.vcproj
  is built. (If entire solution is built, run only onece)

* When OpenSSL sources are modified, because build_ssl.py always runs,
  correctly OpenSSL are rebuilt.

* Module/_ssl.c or Module/_hashlib.c are rebuilt if they or
  include files refereed by them are not modified.

Can you try this? (Only Debug|Win32 and Release|Win32 are implemented)

--
Added file: http://bugs.python.org/file18974/py3k_better_build_ssl.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


--
resolution:  -> fixed
status: open -> closed
versions:  -Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

I committed py3k_openssl.patch in r84957(py3k).
I won't merge into release27-maint nor release31-maint
because they are built against openssl-0.9.x and
don't have *.asm copy code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Oops, I missed your post. Thank you, I'll commit like that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

I want to commit py3k_openssl.patch for now, because
it is much better than before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


Added file: http://bugs.python.org/file18949/py3k_openssl_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Well, I noticed py3k_openssl.patch can suppress rebuild
> of OpenSSL nicely, but from IDE, _ssl and _hashlib
> are always rebuilt. It doesn't take so much time though.
> 
> With py3k_openssl_v2.patch, we can supress OpenSSL and
> python project rebuild nicely, but we cannot rebuild
> _ssl and _hashlib from IDE after OpenSSL sources are
> modified. We need to call "python_d build_ssl.py ..."
> manually.

I think it's better to rebuild everytime than have to invoke a console
command manually.
Also, as you say, building _ssl and hashlib is fast. The problem with
rebuilding OpenSSL is that it's very slow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto :


Removed file: http://bugs.python.org/file18948/py3k_openssl_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Thank you for the test.

Well, I noticed py3k_openssl.patch can suppress rebuild
of OpenSSL nicely, but from IDE, _ssl and _hashlib
are always rebuilt. It doesn't take so much time though.

With py3k_openssl_v2.patch, we can supress OpenSSL and
python project rebuild nicely, but we cannot rebuild
_ssl and _hashlib from IDE after OpenSSL sources are
modified. We need to call "python_d build_ssl.py ..."
manually.

I cannot find the best way for this issue. :-(

--
Added file: http://bugs.python.org/file18948/py3k_openssl_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> This is the patch I'm thinking of. I confirmed this works
> on VS8.0. (After replaced "..\\.." with "..\\..\\..")

Works here too (VS 2008)!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

This is the patch I'm thinking of. I confirmed this works
on VS8.0. (After replaced "..\\.." with "..\\..\\..")

E:\PYTHON~1\py3k\PC\VS8.0>python_d.exe build_ssl.py Release Win32 -a
Found a working perl at 'C:\Perl\bin\perl.exe'
Found an SSL directory at '..\..\..\openssl-1.0.0a'
Executing ssl makefiles: nmake /nologo -f "ms\nt.mak"
Building OpenSSL
copy ".\crypto\buildinf.h" "tmp32\buildinf.h"
Copied one file.
copy ".\crypto\opensslconf.h" "inc32\openssl\opensslconf.h"
Copied one file.
[45178 refs]

By this change, two header files are still copied. I feel
it's strange header files are modified but none of sources
are not re-built.

--
Added file: http://bugs.python.org/file18935/py3k_openssl.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

- only when
+ when

P.S.
I cannot figure out how to solve this error.
http://www.python.org/dev//buildbot/builders/x86%20Windows7%203.x/builds/1593/steps/compile/logs/stdio

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

I'll revert my commits because I noticed after perl source
like openssl-1.0.0a/crypto/x86cpuid.pl was modified,
unnecessary rebuild happened again.

Appropriate fix will be "only copies *.asm if there are not
in tmp32/" as comments in PCBuild/build_ssl.py saids.(Probably
this copying is not needed only when Perl is available,
I suppose)

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Thanks. I've committed in r84902(py3k).

--
resolution:  -> fixed
status: open -> closed
versions: +Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

Antoine Pitrou  added the comment:

The patch works here (VS 2008).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

Here is the result of second run.

-- ビルド開始: プロジェクト: _ssl, 構成: Debug Win32 --
ビルド前のイベントを実行しています...
Can not find a suitable PERL:
 NO perl interpreters were found on this machine at all!
 Please install ActivePerl and ensure it appears on your path
No Perl installation was found. Existing Makefiles are used.
Found a working perl at 'None'
Found an SSL directory at '..\..\..\openssl-1.0.0a'
Executing ssl makefiles: nmake /nologo -f "ms\nt.mak"
Building OpenSSL
[40162 refs]
コンパイルしています...
_ssl.c
..\..\Modules\_ssl.c(583) : warning C4090: '=' : 異なる 'const' 修飾子です。
..\..\Modules\_ssl.c(930) : warning C4090: '=' : 異なる 'const' 修飾子です。
リンクしています...
   ライブラリ E:\python-dev\py3k\PC\VS8.0\\_ssl_d.lib とオブジェクト 
E:\python-dev\py3k\PC\VS8.0\\_ssl_d.exp を作成中
ビルドログは "file://E:\python-dev\py3k\PC\VS8.0\Win32-temp-Debug\_ssl\BuildLog.htm" 
に保存されました。
_ssl - エラー 0、警告 2
== ビルド: 1 正常終了、0 失敗、7 更新、0 スキップ ==

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Hirokazu Yamamoto]

Hirokazu Yamamoto  added the comment:

I hope attached patch will fix this. I used shutil.copy2
to retain modified time. (Actually, I tested on VS8.0 with
equivalent change, I didn't test this file directly)

--
keywords: +patch
nosy: +ocean-city
Added file: 
http://bugs.python.org/file18911/py3k_supress_rebuild_of_openssl.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9552] ssl build under Windows always rebuilds OpenSSL

[Antoine Pitrou]

New submission from Antoine Pitrou :

The build steps for _ssl and _hashlib under Windows always rebuild the same 
intermediate files, even if no change was recorded since the last build. This 
makes building the whole project longer than it should be.

Here is the (trimmed) log:

-- Début de la génération : Projet : _ssl, Configuration : Debug Win32 
--
Exécution d'un événement avant génération...
Found a working perl at 'C:\Perl\bin\perl.exe'
Found an SSL directory at '..\..\openssl-1.0.0a'
Executing ssl makefiles: nmake /nologo -f "ms\nt.mak"
Building OpenSSL
 copy ".\crypto\buildinf.h" "tmp32\buildinf.h"
1 fichier(s) copié(s).
 copy ".\crypto\opensslconf.h" "inc32\openssl\opensslconf.h"
1 fichier(s) copié(s).
 nasmw -f win32 -o tmp32\x86cpuid.obj tmp32\x86cpuid.asm
 nasmw -f win32 -o tmp32\md5-586.obj tmp32\md5-586.asm
[... snip many asm files ...]
 nasmw -f win32 -o tmp32\wp-mmx.obj tmp32\wp-mmx.asm
 lib /nologo /out:out32\libeay32.lib 
@C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nm92.tmp
 link /nologo /subsystem:console /opt:ref /debug /out:out32\md4test.exe 
@C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nm97.tmp
 IF EXIST out32\md4test.exe.manifest mt -nologo -manifest 
out32\md4test.exe.manifest -outputresource:out32\md4test.exe;1
 link /nologo /subsystem:console /opt:ref /debug /out:out32\md5test.exe 
@C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nm99.tmp
 IF EXIST out32\md5test.exe.manifest mt -nologo -manifest 
out32\md5test.exe.manifest -outputresource:out32\md5test.exe;1
 link /nologo /subsystem:console /opt:ref /debug /out:out32\shatest.exe 
@C:\DOCUME~1\ADMINI~1\LOCALS~1\Temp\nm9B.tmp
[... snip many exe files ...]
 IF EXIST out32\openssl.exe.manifest mt -nologo -manifest 
out32\openssl.exe.manifest -outputresource:out32\openssl.exe;1
[44763 refs]
Compilation en cours...
_ssl.c
..\Modules\_ssl.c(583) : warning C4090: '=' : qualificateurs 'const' différents
..\Modules\_ssl.c(930) : warning C4090: '=' : qualificateurs 'const' différents
Édition des liens en cours...
   Création de la bibliothèque Z:\py3k\__svn__\PCbuild\\_ssl_d.lib et de 
l'objet Z:\py3k\__svn__\PCbuild\\_ssl_d.exp
Le journal de génération a été enregistré à l'emplacement 
"file://Z:\py3k\__svn__\PCbuild\Win32-temp-Debug\_ssl\BuildLog.htm"
_ssl - 0 erreur(s), 2 avertissement(s)

--
components: Build, Windows
messages: 113497
nosy: brian.curtin, loewis, pitrou, tim.golden
priority: low
severity: normal
status: open
title: ssl build under Windows always rebuilds OpenSSL
type: behavior
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com