[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Roundup Robot]

Roundup Robot added the comment:

New changeset eead4be1bdd9 by Vinay Sajip in branch 'default':
Closed #9556: Allowed specifying a time-of-day for a TimedRotatingFileHandler 
to rotate.
http://hg.python.org/cpython/rev/eead4be1bdd9

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Tshepang Lekhonkhobe]

Changes by Tshepang Lekhonkhobe :


--
nosy: +tshepang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Vinay Sajip added the comment:

Thanks for the comments on Rietveld - patch updated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Changes by Vinay Sajip :


Added file: http://bugs.python.org/file27693/b178bbafd564.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Changes by Vinay Sajip :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Changes by Vinay Sajip :


--
keywords: +patch
Added file: http://bugs.python.org/file27687/7b2c68a00118.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Vinay Sajip added the comment:

Thanks for the patch. I've added the weekly test and the documentation update, 
can you take a look?

--
hgrepos: +156

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Ronald Oussoren]

Ronald Oussoren added the comment:

An 'atTime' argument would work. I'm currently using a subclass of 
BaseRotatingHandler that implements just the 'MIDNIGHT' option of 
TimedRotatingFileHandler  with a rotation hour argument.

The attached patch is a first attempt at implementing the 'atTime' option, it 
is currently lacking documentation and tests for the 'WEEKLY' value for 'when'.

--
status: pending -> open
versions: +Python 3.4 -Python 3.2
Added file: http://bugs.python.org/file27667/issue9556.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Vinay Sajip]

Vinay Sajip  added the comment:

One way of implementing this is to use an additional optional "atTime" 
parameter which is a datetime.time instance, defaulting to None; a specified 
value would only be used if a 'when' value of 'D' or 'MIDNIGHT' were specified. 
In that case, computeRollover would be called with the specified time instead 
of the current time.

Would that meet your requirements?

--
assignee:  -> vinay.sajip
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Éric Araujo]

Éric Araujo  added the comment:

Adding the logging maintainer to nosy. (BTW Vinay, Misc/maintainers.rst says 
your roundup name is “vsajip”)

--
nosy: +merwok, vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Ronald Oussoren]

Changes by Ronald Oussoren :


--
type: behavior -> feature request

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9556] Specifying the time a TimedRotatingFileHandler rotates

[Ronald Oussoren]

New submission from Ronald Oussoren :

The logging module contains a TimedRotatingFileHandler that automaticly rotates 
the logfile after a specified interval.

This class misses an important feature: it is not possible to specify at what 
time the file should be rotated, unless that time is midnight.

My usecase: one of our customers works night shifts which means that rotating 
logfiles at midnight means that files get rotated halfway through a shift 
instead of at the end of one.

We'd like to be able to specify that logfiles get rotated at a specific time 
(such as 7:00AM).

--
components: Library (Lib)
messages: 113527
nosy: ronaldoussoren
priority: normal
severity: normal
stage: needs patch
status: open
title: Specifying the time a TimedRotatingFileHandler rotates
type: behavior
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com