[issue9572] IOError or OSError in test_multiprocessing

2010-08-26 Thread Florent Xicluna 

Florent Xicluna florent.xicl...@gmail.com added the comment:

Łukasz,

_closing is not necessary on FileIO instances. The class already declares an 
__exit__ method which takes care of closing file.

 import io
 f = io.FileIO('/tmp/test_closing', 'wb')
 f.closed
False

 f.__exit__()
 f.closed
True

Since both IOError and OSError are direct subclasses of EnvironmentError, we 
can use this in the except clause.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9572
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9572] IOError or OSError in test_multiprocessing

2010-08-26 Thread Florent Xicluna 

Florent Xicluna florent.xicl...@gmail.com added the comment:

Patch.

--
keywords: +patch
Added file: http://bugs.python.org/file18649/issue9572_oserror.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9572
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9572] IOError or OSError in test_multiprocessing

2010-08-26 Thread Brett Cannon 

Brett Cannon br...@python.org added the comment:

r84329 has the fix. I decided to catch IOError and OSError separately rather 
than EnvironmentError as a blanket 'except' clause; explicit is better than 
implicit and all.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9572
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9572] IOError or OSError in test_multiprocessing

2010-08-25 Thread Florent Xicluna 

Florent Xicluna florent.xicl...@gmail.com added the comment:

This one looks very similar (r84315 on i386 Ubuntu 3.x buildbot):

./python -Wd -E -bb ./Lib/test/regrtest.py -uall -rwW -l 
== CPython 3.2a1+ (py3k:84315, Aug 25 2010, 17:07:54) [GCC 4.6.0 20100814 
(experimental) [trunk revision 163239]]
==   Linux-2.6.32-24-server-i686-with-debian-squeeze-sid little-endian
==   
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/build/test_python_17577
Using random seed 4479416
[  1/346] test_thread
[  2/346] test_hash
[  3/346] test_zipfile64
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long 
time to run
[  4/346] test_dbm_gnu
test_dbm_gnu skipped -- No module named _gdbm
[  5/346] test_funcattrs
[  6/346] test_http_cookies
[  7/346] test_multiprocessing
Process Process-24:
Traceback (most recent call last):
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/process.py,
 line 233, in _bootstrap
self.run()
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/process.py,
 line 88, in run
self._target(*self._args, **self._kwargs)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/test/test_multiprocessing.py,
 line 1260, in _putter
manager.connect()
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/managers.py,
 line 477, in connect
conn = Client(self._address, authkey=self._authkey)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/connection.py,
 line 427, in XmlClient
import xmlrpc.client as xmlrpclib
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 450, in load_module
return self._load_module(fullname)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 155, in decorated
return fxn(self, module, *args, **kwargs)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 344, in _load_module
code_object = self.get_code(name)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 437, in get_code
self.set_data(bytecode_path, data)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 495, in set_data
_os.mkdir(parent)
OSError: [Errno 17] File exists: 
'/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/xmlrpc/__pycache__'
test test_multiprocessing failed -- Traceback (most recent call last):
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/test/test_multiprocessing.py,
 line 1273, in test_rapid_restart
queue = manager.get_queue()
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/managers.py,
 line 644, in temp
token, exp = self._create(typeid, *args, **kwds)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/managers.py,
 line 542, in _create
conn = self._Client(self._address, authkey=self._authkey)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/multiprocessing/connection.py,
 line 427, in XmlClient
import xmlrpc.client as xmlrpclib
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 450, in load_module
return self._load_module(fullname)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 155, in decorated
return fxn(self, module, *args, **kwargs)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 344, in _load_module
code_object = self.get_code(name)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 437, in get_code
self.set_data(bytecode_path, data)
  File 
/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/importlib/_bootstrap.py,
 line 495, in set_data
_os.mkdir(parent)
OSError: [Errno 17] File exists: 
'/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/xmlrpc/__pycache__'

http://www.python.org/dev/buildbot/builders/i386 Ubuntu 3.x/builds/2005

--
status: closed - open
title: IOError in test_multiprocessing - IOError or OSError in 
test_multiprocessing

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9572
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9572] IOError or OSError in test_multiprocessing

2010-08-25 Thread Łukasz Czuja 

Łukasz Czuja luk...@czuja.pl added the comment:

I Had the same issue while using the lib. I had to replace every: IOError with 
(IOError, OSError) to catch both and just then compare exc.errno.

Also in your r84271 commit, on line 507 you did:

507 :   with _io.FileIO(path, 'wb') as file: 

shouldn't it be:

507 :   with _closing(_io.FileIO(path, 'wb')) as file: 

as in previous commit? In case of an error, you're not closing the file 
properly. Or am I reading that wrong?

Cheers.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9572
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com