[issue9588] Skip subprocess shell tests on Windows per file association setup

[Brian Curtin]

Brian Curtin  added the comment:

Yeah that's much better :)
I should have asked if you left out sys.executable out intentionally before 
coming up with my patch...I assumed it was intended to be different due to 
shell=1 or something.

Go ahead and apply if you want.

--
assignee: brian.curtin -> tim.golden

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9588] Skip subprocess shell tests on Windows per file association setup

[Tim Golden]

Tim Golden  added the comment:

Assuming I understand you correctly, could I propose this rather less involved 
patch which simply specifies the sys.executable as part of the command line. 
The test doesn't propose to test file associations and indeed two of the test 
already fill in the executable

--
Added file: http://bugs.python.org/file18511/9588.exec.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9588] Skip subprocess shell tests on Windows per file association setup

[Brian Curtin]

Brian Curtin  added the comment:

Attached is a patch that fixes this for me, and I *think* it's looking in the 
most correct area for the information.

Tim or any other Windows users, would you mind seeing that the skip does not 
occur on your machines, thus allowing it to properly run those tests?

--
keywords: +patch
Added file: http://bugs.python.org/file18502/issue9588.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9588] Skip subprocess shell tests on Windows per file association setup

[Brian Curtin]

New submission from Brian Curtin :

The fix for #2304 causes issues on Windows if you have file associations setup 
that aren't Python interpters. In my case I have an association setup to open 
.py files in gvim, which causes the shell tests to hang until I quit the 
editor, then it fails because the output from gvim (nothing) doesn't match what 
it would when run through an interpreter.

CommandsWithSpaces.test_shell_* tests should have a skip condition which checks 
file associations before running. The info is stored somewhere in the registry, 
so it should be easy to see that, e.g., gvim.exe isn't a valid Python 
interpreter.

This issue only affects me at the moment, but it could affect other users who 
have tweaked file associations.

--
assignee: brian.curtin
components: Tests, Windows
messages: 113794
nosy: brian.curtin, tim.golden
priority: low
severity: normal
stage: needs patch
status: open
title: Skip subprocess shell tests on Windows per file association setup
type: behavior
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com